Undo cancer_group manual override for select sample_ID as per OPC_566 #600
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
Fix cancer_group and subtype mismatch for BS_YZD4SSMA
What scientific question is your analysis addressing?
There was a manual hard-coding of cancer_group for a specific sample_id. This caused the cancer_group and subtype mismatch. I investigated the source to fix the mismatch.
What was your approach?
Review the molecular-subtyping-integrate module to investigate the values in the input data sources
Review the KF_BS 'BS_YZD4SSMA' to locate manual override.
Undo such hardcoding, and review the result files to confirm cancer_group and subtype match.
What GitHub issue does your pull request address?
Issue 566
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Please review the result files to confirm the data for 'BS_YZD4SSMA' is acceptable.
Is there anything that you want to discuss further?
No.
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Yes.
Results
What types of results are included (e.g., table, figure)?
What is your summary of the results?
Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.