Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update MB SHH abridged output #602

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

rjcorb
Copy link

@rjcorb rjcorb commented Jul 24, 2024

Purpose/implementation Section

What scientific question is your analysis addressing?

This PR updates the molecular-subtyping-MB analysis module to remove non-relevant columns from abridged output generated by 05-subtype-mb-shh.R.

What was your approach?

Removed SHH_subtype column from mb_shh_molecular_subtypes.tsv, since molecular_subtype column contains complete information on SHH subtype classification.

What GitHub issue does your pull request address?

#599

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Results

What types of results are included (e.g., table, figure)?

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@rjcorb rjcorb requested a review from a team as a code owner July 24, 2024 13:54
Copy link
Member

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @rjcorb are the mutation calls being removed expected here?

@rjcorb
Copy link
Author

rjcorb commented Aug 2, 2024

@jharenza I reran the script and am still getting those changes to mb_shh_subtypes_w_molecular_data.tsv. For those biospecimen IDs that went from non-NA csq to NA, I don't see those IDs in either maf file. So I'm not sure how non-NA csqs were ever reported in those cases...

Copy link
Member

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what is happening, but when I run this, I get the former result, with the non-NA results.

Line 109 for example:
Screenshot 2024-08-15 at 6 20 30 PM

@jharenza
Copy link
Member

checks should all pass now, but can you double check re: my comments above - is your data linked to v15, not testing or something odd by chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants