Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate file headers #5207

Merged
merged 51 commits into from
Mar 7, 2024
Merged

Automate file headers #5207

merged 51 commits into from
Mar 7, 2024

Conversation

niloc132
Copy link
Member

@niloc132 niloc132 commented Mar 1, 2024 •
edited

Automates license headers and updates generated headers to more
clearly indicate what should be changed. Removes spotless exclusions
where possible, using file comments instead when necessary. Disables
spotless for files not under the dh license.

This will fail to build, the next commit, #5208 will apply these
changes across the codebase.

Fixes #1997

@niloc132
Configure spotless plugin for license headers
43812f1
@niloc132
Generated headers need an obvious signature
722c16d
@niloc132
Avoid license headers in generated grpc/pb files
a83308a
@niloc132
Avoid license headers in grpc py files
481b5d8
@niloc132
Exclude config files
1f33a7e
@niloc132
Avoid overwriting replicted headers
7fdac65
@niloc132
Handle replication for shorter headers
7805708
@niloc132
safe replication updates
8e0156e
@niloc132
wip
da8292e
@niloc132
Don't replace apache headers in grpc-java
69889b9
@niloc132
License header attempt
a18bdf9
@niloc132
Attempt to update code generators to match
d4e661c
@niloc132
Add marker for generated headers
232a3a2
@niloc132
Update replication tasks to use the new format
d3f0415
@niloc132
Allow more files to be spotless'd
3008408
@niloc132
Update replication to write gradle task to run it
18af78e
@niloc132
Revert header changes before we review
2f517b7
@niloc132
Temporarily disable spotless headers
f7d695b
@niloc132
Spotless on codegen classes
702b9e5
@niloc132
Spotless on non-generated StateManager types
976fe3d
@niloc132
Disable formatting on javapoet-generated types
373a421
@niloc132
Adjust comment-consuming code
6448485
@niloc132
Disable formatting on template files
43354aa
@niloc132
fix repl primitives
3b2120f
@niloc132
disable more formatting
4add80c
@niloc132
Extra newline after generated header
82197ea
@niloc132
Python files need some content after license header
776d564
@niloc132
Update copyright year
a5dc237
@niloc132
Restore copyright header change, disable all exclusions
8924a2b
@niloc132
Disable formatter for other generated classes
d3019c4
@niloc132 niloc132 mentioned this pull request Mar 1, 2024
Merged
@niloc132 niloc132 changed the title Update license headers Automate file headers Mar 1, 2024
devinrsmith
devinrsmith reviewed Mar 4, 2024
View reviewed changes
Copy link
Member

@devinrsmith devinrsmith left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to do shallow review. Things look ok. Will try running commands. The // @formatter:off is much nicer than trying to finely specify the excludes.

@niloc132
Copy link
Member Author

niloc132 commented Mar 5, 2024

Tests are passing of the finished product: https://github.com/niloc132/deephaven-core/actions/runs/8162832698

@niloc132 niloc132 marked this pull request as ready for review March 7, 2024 00:41
@devinrsmith devinrsmith merged commit 7113b72 into deephaven:main Mar 7, 2024
16 of 19 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devinrsmith devinrsmith devinrsmith left review comments

@chipkent chipkent Awaiting requested review from chipkent chipkent is a code owner

@jmao-denver jmao-denver Awaiting requested review from jmao-denver jmao-denver is a code owner

@rcaudy rcaudy Awaiting requested review from rcaudy rcaudy is a code owner

@kosak kosak Awaiting requested review from kosak kosak is a code owner

Assignees
No one assigned
Labels
build NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed.
Projects
None yet
Milestone
2. February 2024 (end of month)
Development

Successfully merging this pull request may close these issues.

Replace license-gradle-plugin with spotless
2 participants
@niloc132 @devinrsmith