Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace license-gradle-plugin with spotless #1997

Closed
3 tasks done
devinrsmith opened this issue Feb 17, 2022 · 0 comments · Fixed by #5207 or #5208
Closed
3 tasks done

Replace license-gradle-plugin with spotless #1997

devinrsmith opened this issue Feb 17, 2022 · 0 comments · Fixed by #5207 or #5208
Assignees
@devinrsmith
Labels
feature request New feature or request
Milestone
Backlog

Comments

@devinrsmith
Copy link
Member

devinrsmith commented Feb 17, 2022 •
edited by niloc132
Loading

We (maybe) are using license-gradle-plugin for a copyright notice, but I don't think it's been automated or has been particularly useful. It's likely that we can replace and automate the functionality with spotless (see #404).

  • Remove old plugin, no longer compatible with relatively recent gradle versions
  • Update codegen tools to follow a license header pattern that spotless can get along with
  • Enforce license headers on all source files (c++, python, r, go, proto...) with spotless.
@devinrsmith devinrsmith added the feature request New feature or request label Feb 17, 2022
@devinrsmith devinrsmith added this to the Backlog milestone Feb 17, 2022
@devinrsmith devinrsmith self-assigned this Feb 17, 2022
@devinrsmith devinrsmith mentioned this issue Mar 31, 2023
Closed
devinrsmith added a commit to devinrsmith/deephaven-core that referenced this issue Apr 19, 2023
@devinrsmith
Remove license-gradle-plugin
9edc0fe 
Fixes deephaven#1997
@devinrsmith devinrsmith mentioned this issue Apr 19, 2023
Closed
@niloc132 niloc132 mentioned this issue Feb 26, 2024
Merged
@niloc132 niloc132 changed the title Remove license-gradle-plugin Replace license-gradle-plugin with spotless Feb 26, 2024
This was referenced Mar 1, 2024
Merged
Merged
devinrsmith pushed a commit that referenced this issue Mar 7, 2024
@niloc132
Update and automate file headers (#5208)
da73346 
Updates all file headers to match our new format.

Fixes #1997
mofojed pushed a commit that referenced this issue May 16, 2024
@github-actions @deephaven-internal
Update web version 0.78.0 (#5500)
a6d51c5 
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.78.0

### Bug Fixes

* "Delete Selected Rows" bug for tables with no key columns ([#1996](deephaven/web-client-ui#1996)) ([37fe009](deephaven/web-client-ui@37fe009))
* Improve the look of the error view ([#2001](deephaven/web-client-ui#2001)) ([3236c9b](deephaven/web-client-ui@3236c9b))
* PouchStorageTable using incorrect $ne operator ([#2011](deephaven/web-client-ui#2011)) ([6cf1240](deephaven/web-client-ui@6cf1240))
* Use picker for iris grid partition selector  ([#2012](deephaven/web-client-ui#2012)) ([b61c518](deephaven/web-client-ui@b61c518))
* useViewportData - memoize subscriptions and first row of viewport ([#2008](deephaven/web-client-ui#2008)) ([2246a4a](deephaven/web-client-ui@2246a4a))


### Code Refactoring

* Rename `ButtonGroup` to `SplitButtonGroup` ([#1997](deephaven/web-client-ui#1997)) ([95a589c](deephaven/web-client-ui@95a589c))


### Features

* Add JS Plugin Information ([#2002](deephaven/web-client-ui#2002)) ([6ff378c](deephaven/web-client-ui@6ff378c))
* add middle click dashboard tab deletion ([#1992](deephaven/web-client-ui#1992)) ([c922f87](deephaven/web-client-ui@c922f87))
* ListView actions ([#1968](deephaven/web-client-ui#1968)) ([8e325ec](deephaven/web-client-ui@8e325ec))
* Make grid widget respect global formatter settings ([#1995](deephaven/web-client-ui#1995)) ([d1fba8f](deephaven/web-client-ui@d1fba8f))
* update @vscode/codicons to 0.36 ([#2010](deephaven/web-client-ui#2010)) ([3a6a439](deephaven/web-client-ui@3a6a439))


### Performance Improvements

* Improve performance of lots of grids in a dashboard ([#1987](deephaven/web-client-ui#1987)) ([3de52d6](deephaven/web-client-ui@3de52d6))


### BREAKING CHANGES

* Renamed @deephaven/components `ButtonGroup` to
`SplitButtonGroup`


Co-authored-by: deephaven-internal <66694643+deephaven-internal@users.noreply.github.com>
stanbrub pushed a commit that referenced this issue May 17, 2024
@github-actions @deephaven-internal @stanbrub
Update web version 0.78.0 (#5500)
68b228e 
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.78.0

### Bug Fixes

* "Delete Selected Rows" bug for tables with no key columns ([#1996](deephaven/web-client-ui#1996)) ([37fe009](deephaven/web-client-ui@37fe009))
* Improve the look of the error view ([#2001](deephaven/web-client-ui#2001)) ([3236c9b](deephaven/web-client-ui@3236c9b))
* PouchStorageTable using incorrect $ne operator ([#2011](deephaven/web-client-ui#2011)) ([6cf1240](deephaven/web-client-ui@6cf1240))
* Use picker for iris grid partition selector  ([#2012](deephaven/web-client-ui#2012)) ([b61c518](deephaven/web-client-ui@b61c518))
* useViewportData - memoize subscriptions and first row of viewport ([#2008](deephaven/web-client-ui#2008)) ([2246a4a](deephaven/web-client-ui@2246a4a))


### Code Refactoring

* Rename `ButtonGroup` to `SplitButtonGroup` ([#1997](deephaven/web-client-ui#1997)) ([95a589c](deephaven/web-client-ui@95a589c))


### Features

* Add JS Plugin Information ([#2002](deephaven/web-client-ui#2002)) ([6ff378c](deephaven/web-client-ui@6ff378c))
* add middle click dashboard tab deletion ([#1992](deephaven/web-client-ui#1992)) ([c922f87](deephaven/web-client-ui@c922f87))
* ListView actions ([#1968](deephaven/web-client-ui#1968)) ([8e325ec](deephaven/web-client-ui@8e325ec))
* Make grid widget respect global formatter settings ([#1995](deephaven/web-client-ui#1995)) ([d1fba8f](deephaven/web-client-ui@d1fba8f))
* update @vscode/codicons to 0.36 ([#2010](deephaven/web-client-ui#2010)) ([3a6a439](deephaven/web-client-ui@3a6a439))


### Performance Improvements

* Improve performance of lots of grids in a dashboard ([#1987](deephaven/web-client-ui#1987)) ([3de52d6](deephaven/web-client-ui@3de52d6))


### BREAKING CHANGES

* Renamed @deephaven/components `ButtonGroup` to
`SplitButtonGroup`


Co-authored-by: deephaven-internal <66694643+deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devinrsmith devinrsmith

Labels
feature request New feature or request
Projects
None yet
Milestone
Backlog
1 participant
@devinrsmith