Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and automate file headers #5208

Merged
merged 53 commits into from
Mar 7, 2024

Conversation

niloc132
Copy link
Member

@niloc132 niloc132 commented Mar 1, 2024

Updates all file headers to match our new format.

Fixes #1997

@niloc132 niloc132 force-pushed the nightly/1997-file-headers branch 3 times, most recently from 47c2b1c to 10cee09 Compare March 1, 2024 18:20
@devinrsmith
Copy link
Member

I think it might make sense to force-merge #5207 first (with its failing tests); that work product is about +1/-1k vs this PR at +71/-49k. We might appreciate being able to separate the history in the future.

@niloc132 niloc132 mentioned this pull request Mar 7, 2024
devinrsmith pushed a commit that referenced this pull request Mar 7, 2024
Automates license headers and updates generated headers to more clearly indicate what should be changed. Removes spotless exclusions where possible, using file comments instead when necessary. Disables spotless for files not under the dh license.

This will fail to build, the next commit, #5208 will apply these changes across the codebase.

Fixes #1997
@niloc132 niloc132 enabled auto-merge (squash) March 7, 2024 01:04
@devinrsmith devinrsmith merged commit da73346 into deephaven:main Mar 7, 2024
19 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace license-gradle-plugin with spotless
2 participants