-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and automate file headers #5208
Merged
devinrsmith
merged 53 commits into
deephaven:main
from
niloc132:nightly/1997-file-headers
Mar 7, 2024
Merged
Update and automate file headers #5208
devinrsmith
merged 53 commits into
deephaven:main
from
niloc132:nightly/1997-file-headers
Mar 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c88e6f5
to
ff90b5b
Compare
47c2b1c
to
10cee09
Compare
10cee09
to
42b8330
Compare
42b8330
to
bc6c3b0
Compare
I think it might make sense to force-merge #5207 first (with its failing tests); that work product is about +1/-1k vs this PR at +71/-49k. We might appreciate being able to separate the history in the future. |
bc6c3b0
to
44659f3
Compare
Merged
devinrsmith
pushed a commit
that referenced
this pull request
Mar 7, 2024
Automates license headers and updates generated headers to more clearly indicate what should be changed. Removes spotless exclusions where possible, using file comments instead when necessary. Disables spotless for files not under the dh license. This will fail to build, the next commit, #5208 will apply these changes across the codebase. Fixes #1997
44659f3
to
bcf8ac5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates all file headers to match our new format.
Fixes #1997