-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify the release process by linking to release notes instead of copy/pasting them #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a chicken-and-egg scenario where we don't have the release notes to include in the version bump PR until we create a GitHub release... but we don't want to publish the release until the commit bumping the version actually lands. The last few times I've cut a `fetch-metadata` release, I've been surprised how I always forget the intricate dance to navigate this chicken-and-egg. I don't think the juice is worth the squeeze... no one really looks at the changelog notes in the PR, and if in fact having the release notes two different places introduces a risk of drift because both the PR description and the git tag for the release can be edited later on... only the commit history is actually immutable. So if either is edited w/o editing the other, they're out of sync. The odds of that are low--we rarely edit release notes--but still life is simpler if we merely point the commit/PR description at the URL for the release notes and manage those in a single place. This also lets us script creating the PR, which is one less thing to do manually.
jeffwidman
commented
Apr 21, 2023
``` | ||
- Copy the release notes from the draft release to the PR description. This is optional, but looks much nicer than a bare URL. | ||
- Merge the PR after getting it reviewed | ||
- Publish the draft release found at https://github.com/dependabot/fetch-metadata/releases/tag/untagged-XXXXXX | ||
- Update the `v1` tracking tag to point to the new version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could automate this as well, so that anytime a new v1.x
version is tagged, the v1
tracking tag is updated to point to it. Or is that too much "magic"??
pavera
approved these changes
Apr 21, 2023
ilkka
added a commit
to ilkka/nisse
that referenced
this pull request
Sep 20, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [dependabot/fetch-metadata](https://github.com/dependabot/fetch-metadata) | action | minor | `v1.3.1` -> `v1.6.0` | --- ### Release Notes <details> <summary>dependabot/fetch-metadata (dependabot/fetch-metadata)</summary> ### [`v1.6.0`](https://github.com/dependabot/fetch-metadata/releases/tag/v1.6.0) [Compare Source](https://github.com/dependabot/fetch-metadata/compare/v1.5.1...v1.6.0) #### What's Changed - Add `.vscode` folder to `.gitignore` by [@​timothy-humphrey](https://github.com/timothy-humphrey) in [dependabot/fetch-metadata#385 - Support for Grouped Updates by [@​Nishnha](https://github.com/Nishnha) in [dependabot/fetch-metadata#396 - v1.6.0 by [@​fetch-metadata-action-automation](https://github.com/fetch-metadata-action-automation) in [dependabot/fetch-metadata#403 #### New Contributors - [@​timothy-humphrey](https://github.com/timothy-humphrey) made their first contribution in [dependabot/fetch-metadata#385 **Full Changelog**: dependabot/fetch-metadata@v1...v1.6.0 ### [`v1.5.1`](https://github.com/dependabot/fetch-metadata/releases/tag/v1.5.1) [Compare Source](https://github.com/dependabot/fetch-metadata/compare/v1.5.0...v1.5.1) #### What's Changed Bugfix: - Fix library parser to trim trailing LF by [@​kachick](https://github.com/kachick) in [dependabot/fetch-metadata#380 Dep bumps that are trivial so decided to keep this a patch release: - Bump yargs from 17.7.1 to 17.7.2 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#379 - Bump [@​types/node](https://github.com/types/node) from 20.2.1 to 20.2.3 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#382 Internal-facing infra changes: - GroupPR's for `eslint`-related deps by [@​jeffwidman](https://github.com/jeffwidman) in [dependabot/fetch-metadata#374 - Bump the eslint-dependencies group with 3 updates by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#375 - Bump the eslint-dependencies group with 2 updates by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#378 - Switch to using an app token instead of a PAT by [@​jeffwidman](https://github.com/jeffwidman) in [dependabot/fetch-metadata#362 - v1.5.1 by [@​fetch-metadata-action-automation](https://github.com/fetch-metadata-action-automation) in [dependabot/fetch-metadata#384 **Full Changelog**: dependabot/fetch-metadata@v1...v1.5.1 ### [`v1.5.0`](https://github.com/dependabot/fetch-metadata/releases/tag/v1.5.0) [Compare Source](https://github.com/dependabot/fetch-metadata/compare/v1.4.0...v1.5.0) #### What's Changed New Features: - Added flag if "Maintainer changes" appears in the PR body by [@​mwaddell](https://github.com/mwaddell) in [dependabot/fetch-metadata#174 Bumped Deps: - Bump [@​types/node](https://github.com/types/node) from 18.15.11 to 20.2.1 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#364 - Bump nock from 13.3.0 to 13.3.1 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#366 Docs: - Add minimum permissions to usage example by [@​jablko](https://github.com/jablko) in [dependabot/fetch-metadata#343 - Document verification overrides in readme by [@​jeffwidman](https://github.com/jeffwidman) in [dependabot/fetch-metadata#345 Code cleanup: - Simplify the release process by linking to release notes instead of copy/pasting them by [@​jeffwidman](https://github.com/jeffwidman) in [dependabot/fetch-metadata#347 - Use the full email for the GitHub Actions bot by [@​jeffwidman](https://github.com/jeffwidman) in [dependabot/fetch-metadata#354 - Inline the PR URL by [@​jeffwidman](https://github.com/jeffwidman) in [dependabot/fetch-metadata#359 - No need to request escalated permissions for `GITHUB_TOKEN` by [@​jeffwidman](https://github.com/jeffwidman) in [dependabot/fetch-metadata#357 - Remove unused step by [@​jeffwidman](https://github.com/jeffwidman) in [dependabot/fetch-metadata#358 - Simplify `bin/bump-version` by [@​jeffwidman](https://github.com/jeffwidman) in [dependabot/fetch-metadata#368 - Add a deeplink for tagging releases to the Readme by [@​jeffwidman](https://github.com/jeffwidman) in [dependabot/fetch-metadata#369 - Stop using deprecated `set-output` by [@​jeffwidman](https://github.com/jeffwidman) in [dependabot/fetch-metadata#370 - Add workflow for creating release PR's by [@​jeffwidman](https://github.com/jeffwidman) in [dependabot/fetch-metadata#360 - Add workflow for floating the `v1` tag to the latest release by [@​jeffwidman](https://github.com/jeffwidman) in [dependabot/fetch-metadata#361 **Full Changelog**: dependabot/fetch-metadata@v1...v1.5.0 ### [`v1.4.0`](https://github.com/dependabot/fetch-metadata/releases/tag/v1.4.0) [Compare Source](https://github.com/dependabot/fetch-metadata/compare/v1.3.6...v1.4.0) #### New Features - feat: add option to skip internal verifications by [@​yeikel](https://github.com/yeikel) in [dependabot/fetch-metadata#336 #### Bugfix - Allow leading `v` on commit message versions by [@​jonmcquillan](https://github.com/jonmcquillan) in [dependabot/fetch-metadata#338 #### Dep Bumps - Bump [@​typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin) from 5.48.2 to 5.49.0 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#307 - Bump [@​types/yargs](https://github.com/types/yargs) from 17.0.19 to 17.0.20 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#308 - Bump [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser) from 5.48.2 to 5.49.0 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#309 - Bump eslint from 8.32.0 to 8.33.0 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#315 - Bump [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser) from 5.49.0 to 5.50.0 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#314 - Bump [@​types/yargs](https://github.com/types/yargs) from 17.0.20 to 17.0.22 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#312 - Bump [@​vercel/ncc](https://github.com/vercel/ncc) from 0.36.0 to 0.36.1 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#311 - Bump typescript from 4.9.4 to 4.9.5 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#313 - Bump yargs from 17.6.2 to 17.7.1 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#322 - Bump eslint from 8.33.0 to 8.35.0 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#321 - Bump [@​typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin) from 5.49.0 to 5.54.0 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#319 - Bump [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser) from 5.50.0 to 5.54.0 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#320 - Bump [@​types/node](https://github.com/types/node) from 18.11.18 to 18.14.2 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#318 - Bump [@​types/node](https://github.com/types/node) from 18.14.2 to 18.15.11 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#324 - Bump eslint from 8.35.0 to 8.37.0 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#327 - Bump [@​types/yargs](https://github.com/types/yargs) from 17.0.22 to 17.0.24 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#326 - Bump [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser) from 5.54.0 to 5.57.1 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#330 - Bump [@​typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin) from 5.54.0 to 5.57.1 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#329 - Bump eslint from 8.37.0 to 8.38.0 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#340 - Bump [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser) from 5.57.1 to 5.59.0 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#341 - Bump [@​typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin) from 5.57.1 to 5.59.0 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#342 #### Other - chore(ee): add devcontainer by [@​yeikel](https://github.com/yeikel) in [dependabot/fetch-metadata#337 #### New Contributors - [@​jonmcquillan](https://github.com/jonmcquillan) made their first contribution in [dependabot/fetch-metadata#338 - [@​yeikel](https://github.com/yeikel) made their first contribution in [dependabot/fetch-metadata#337 **Full Changelog**: dependabot/fetch-metadata@v1...v1.4.0 ### [`v1.3.6`](https://github.com/dependabot/fetch-metadata/releases/tag/v1.3.6) [Compare Source](https://github.com/dependabot/fetch-metadata/compare/v1.3.5...v1.3.6) #### What's Changed - Drop mention of "locally" by [@​jeffwidman](https://github.com/jeffwidman) in [dependabot/fetch-metadata#281 - Don't assume `git pull` fetches all branches/tags by [@​jeffwidman](https://github.com/jeffwidman) in [dependabot/fetch-metadata#284 - Clarify release notes slightly by [@​jeffwidman](https://github.com/jeffwidman) in [dependabot/fetch-metadata#283 - Bump eslint-plugin-promise from 6.0.1 to 6.1.1 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#287 - Bump [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser) from 5.38.0 to 5.45.0 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#290 - Bump yargs and [@​types/yargs](https://github.com/types/yargs) by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#286 - Bump [@​types/node](https://github.com/types/node) from 18.11.9 to 18.11.10 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#289 - Bump decode-uri-component from 0.2.0 to 0.2.2 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#291 - Bump yaml from 2.1.1 to 2.1.3 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#288 - Bump [@​types/node](https://github.com/types/node) from 18.11.10 to 18.11.18 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#296 - Bump [@​vercel/ncc](https://github.com/vercel/ncc) from 0.34.0 to 0.36.0 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#294 - Bump dotenv from 16.0.2 to 16.0.3 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#293 - Bump typescript from 4.8.3 to 4.9.4 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#295 - Bump yaml from 2.1.3 to 2.2.1 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#292 - Bump json5 from 1.0.1 to 1.0.2 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#297 - Bump eslint from 8.23.1 to 8.32.0 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#303 - Bump [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser) from 5.45.0 to 5.48.2 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#300 - Bump [@​typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin) from 5.42.0 to 5.48.2 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#302 - Bump eslint-plugin-import from 2.26.0 to 2.27.5 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#301 - Bump nock from 13.2.9 to 13.3.0 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#299 - Bump [@​types/yargs](https://github.com/types/yargs) from 17.0.15 to 17.0.19 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#304 - Fix parser for libraries by [@​kachick](https://github.com/kachick) in [dependabot/fetch-metadata#224 #### New Contributors - [@​kachick](https://github.com/kachick) made their first contribution in [dependabot/fetch-metadata#224 **Full Changelog**: dependabot/fetch-metadata@v1...v1.3.6 ### [`v1.3.5`](https://github.com/dependabot/fetch-metadata/releases/tag/v1.3.5) [Compare Source](https://github.com/dependabot/fetch-metadata/compare/v1.3.4...v1.3.5) #### What's Changed - v1.3.4 Release Notes by [@​Nishnha](https://github.com/Nishnha) in [dependabot/fetch-metadata#267 - docs: fix auto-merge example by [@​rribeiro1](https://github.com/rribeiro1) in [dependabot/fetch-metadata#250 - Bump [@​types/node](https://github.com/types/node) from 18.7.18 to 18.11.9 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#275 - Fix object-shorthand linter warnings by [@​mattt](https://github.com/mattt) in [dependabot/fetch-metadata#276 - Bump [@​actions/core](https://github.com/actions/core) from 1.9.1 to 1.10.0 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#272 - Bump [@​typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin) from 5.38.0 to 5.42.0 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#274 - Bump [@​actions/github](https://github.com/actions/github) from 5.0.3 to 5.1.1 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#271 - Bump yargs and [@​types/yargs](https://github.com/types/yargs) by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#273 - Document steps for cutting a new release by [@​jeffwidman](https://github.com/jeffwidman) in [dependabot/fetch-metadata#252 - Don't bump pin versions in `README.md` by [@​jeffwidman](https://github.com/jeffwidman) in [dependabot/fetch-metadata#280 #### New Contributors - [@​Nishnha](https://github.com/Nishnha) made their first contribution in [dependabot/fetch-metadata#267 - [@​rribeiro1](https://github.com/rribeiro1) made their first contribution in [dependabot/fetch-metadata#250 **Full Changelog**: dependabot/fetch-metadata@v1...v1.3.5 ### [`v1.3.4`](https://github.com/dependabot/fetch-metadata/releases/tag/v1.3.4) [Compare Source](https://github.com/dependabot/fetch-metadata/compare/v1.3.3...v1.3.4) #### What's Changed - Pin only to major version, not full patch version by [@​jeffwidman](https://github.com/jeffwidman) in [dependabot/fetch-metadata#246 - Fix broken logo on readme by [@​jeffwidman](https://github.com/jeffwidman) in [dependabot/fetch-metadata#253 - Bump action to use node16 by [@​quinnjn](https://github.com/quinnjn) in [dependabot/fetch-metadata#251 - Bump [@​typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin) from 5.20.0 to 5.38.0 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#256 - Bump [@​actions/core](https://github.com/actions/core) from 1.6.0 to 1.9.1 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#242 - Bump eslint-config-standard from 16.0.3 to 17.0.0 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#214 - Bump [@​types/node](https://github.com/types/node) from 17.0.25 to 18.7.18 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#255 - Bump [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser) from 5.20.0 to 5.38.0 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#254 - Bump eslint from 8.13.0 to 8.23.1 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#259 - Bump nock from 13.2.4 to 13.2.9 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#260 - Bump yargs and [@​types/yargs](https://github.com/types/yargs) by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#261 - Bump eslint-plugin-promise from 6.0.0 to 6.0.1 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#263 - Bump dotenv from 16.0.0 to 16.0.2 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#262 - Bump [@​vercel/ncc](https://github.com/vercel/ncc) from 0.33.4 to 0.34.0 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#264 - Bump [@​actions/github](https://github.com/actions/github) from 5.0.1 to 5.0.3 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#265 - Bump ts-node from 10.7.0 to 10.9.1 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#266 - Bump typescript from 4.6.3 to 4.8.3 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#257 - Bump yaml from 2.0.1 to 2.1.1 by [@​dependabot](https://github.com/dependabot) in [dependabot/fetch-metadata#258 #### New Contributors - [@​jeffwidman](https://github.com/jeffwidman) made their first contribution in [dependabot/fetch-metadata#246 - [@​quinnjn](https://github.com/quinnjn) made their first contribution in [dependabot/fetch-metadata#251 **Full Changelog**: dependabot/fetch-metadata@v1.3.3...v1.3.4 ### [`v1.3.3`](https://github.com/dependabot/fetch-metadata/releases/tag/v1.3.3) [Compare Source](https://github.com/dependabot/fetch-metadata/compare/v1.3.2...v1.3.3) #### What's Changed - action.yaml: fix skip-commit-verification quoting by [@​jsok](https://github.com/jsok) in [dependabot/fetch-metadata#232 #### New Contributors - [@​jsok](https://github.com/jsok) made their first contribution in [dependabot/fetch-metadata#232 **Full Changelog**: dependabot/fetch-metadata@v1.3.2...v1.3.3 ### [`v1.3.2`](https://github.com/dependabot/fetch-metadata/releases/tag/v1.3.2) [Compare Source](https://github.com/dependabot/fetch-metadata/compare/v1.3.1...v1.3.2) #### What's Changed - Update CODEOWNERS by [@​mattt](https://github.com/mattt) in [dependabot/fetch-metadata#211 - Add 'skip-commit-verification' as an input for GitHub Enterprise Server users by [@​brrygrdn](https://github.com/brrygrdn) in [dependabot/fetch-metadata#225 #### New Contributors - [@​mattt](https://github.com/mattt) made their first contribution in [dependabot/fetch-metadata#211 **Full Changelog**: dependabot/fetch-metadata@v1.3.1...v1.3.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [x] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ilkka/nisse). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi45Ny4xIiwidXBkYXRlZEluVmVyIjoiMzYuOTcuMSIsInRhcmdldEJyYW5jaCI6InRydW5rIn0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a chicken-and-egg scenario where we don't have the release notes to include in the version bump PR until we create a GitHub release... but we don't want to publish the release until the commit bumping the version actually lands.
I don't think the juice is worth the squeeze... no one really looks at the changelog notes in the PR, and if in fact having the release notes two different places introduces a risk of drift because both the PR description and the git tag for the release can be edited later on... only the commit history is actually immutable. So if either is edited w/o editing the other, they're out of sync.
The odds of that are low--we rarely edit release notes--but still life is simpler if we merely point the commit/PR description at the URL for the release notes and manage those in a single place.
This also lets us script creating the PR, which is one less thing to do manually.