Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump xxhash to v2 to fix https://github.com/cespare/xxhash/issues/54 #1790

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Bump xxhash to v2 to fix https://github.com/cespare/xxhash/issues/54 #1790

merged 1 commit into from
Jun 23, 2022

Conversation

mjungsbluth
Copy link

@mjungsbluth mjungsbluth commented Jun 22, 2022

Fixes build issues when using badger in a Golang plugin with 1.17+

See cespare/xxhash#54 for the upstream fix

@mjungsbluth mjungsbluth marked this pull request as draft June 22, 2022 16:05
@CLAassistant
Copy link

CLAassistant commented Jun 22, 2022

CLA assistant check
All committers have signed the CLA.

@mjungsbluth mjungsbluth marked this pull request as ready for review June 22, 2022 16:18
Copy link

@pandeyshubham25 pandeyshubham25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjungsbluth Thanks for the changes! Version upgrade looks good to me

@joshua-goldstein joshua-goldstein merged commit 7d159dd into dgraph-io:master Jun 23, 2022
@mjungsbluth mjungsbluth deleted the fix_xxhash_plugin_build branch June 27, 2022 15:52
joshua-goldstein added a commit that referenced this pull request Feb 9, 2023
mangalaman93 pushed a commit that referenced this pull request Feb 11, 2023
mangalaman93 pushed a commit that referenced this pull request Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants