Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: DLT-1799 move SB to docs - Tabs to Validation Messages #565

Merged
merged 6 commits into from
Nov 28, 2024
Merged

docs: DLT-1799 move SB to docs - Tabs to Validation Messages #565

merged 6 commits into from
Nov 28, 2024

Conversation

ninamarina
Copy link
Contributor

@ninamarina ninamarina commented Nov 19, 2024 •
edited by jira bot
Loading

docs: DLT-1799 move SB to docs - Tabs to Validation Messages

Obligatory GIF (super important!)

Obligatory GIF

🛠️ Type Of Change

These types will increment the version number on release:

  • Fix
  • Feature
  • Performance Improvement
  • Refactor

These types will not increment the version number, but will still deploy to documentation site on release:

  • Documentation
  • Build system
  • CI
  • Style (code style changes, not css changes)
  • Test
  • Other (chore)

📖 Jira Ticket

DLT-1799

📖 Description

Moves SB to docs for the following components:

  • tabs
  • toast
  • toggle
  • tooltip
  • validation messages

@github-actions GitHub Actions
Copy link

Please add either the visual-test-ready or no-visual-test label to this PR depending on whether you want to run visual tests or not.
It is recommended to run visual tests if your PR changes any UI. ‼️

@ninamarina ninamarina added the no-visual-test Add this tag when the PR does not need visual testing label Nov 19, 2024
@ninamarina ninamarina marked this pull request as ready for review November 21, 2024 13:15
braddialpad
braddialpad reviewed Nov 25, 2024
View reviewed changes
Copy link
Contributor

@braddialpad braddialpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! looking good. I think most of the issues I've reported were already issues in the old documentation, but we should fix them regardless.

apps/dialtone-documentation/docs/components/toast.md Outdated Show resolved Hide resolved
apps/dialtone-documentation/docs/components/toast.md Outdated Show resolved Hide resolved
apps/dialtone-documentation/docs/components/toast.md Outdated Show resolved Hide resolved
apps/dialtone-documentation/docs/components/toggle.md Outdated Show resolved Hide resolved
apps/dialtone-documentation/docs/components/toggle.md Outdated Show resolved Hide resolved
apps/dialtone-documentation/docs/.vuepress/exampleComponents/ExampleTabs.vue Show resolved Hide resolved
apps/dialtone-documentation/docs/components/tooltip.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-565/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-565/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-565/

braddialpad
braddialpad approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@braddialpad braddialpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks!

@ninamarina ninamarina merged commit e78aece into staging Nov 28, 2024
10 checks passed
@ninamarina ninamarina deleted the add/docs-tabs branch November 28, 2024 17:38
braddialpad pushed a commit that referenced this pull request Dec 5, 2024
@semantic-release-bot
chore(release): NO-JIRA dialtone/v9.86.1
7bd8155 
## [9.86.1](dialtone/v9.86.0...dialtone/v9.86.1) (2024-12-03)

### Bug Fixes

* **Tokens:** DLT-1961 output font related tokens as rem instead of px ([#576](#576)) ([7241f65](7241f65))

### Documentation

* DLT-1799 move SB to docs - Tabs to Validation Messages ([#565](#565)) ([e78aece](e78aece))
* NO-JIRA fix broken links ([#572](#572)) ([98038c0](98038c0))
braddialpad pushed a commit that referenced this pull request Dec 10, 2024
@semantic-release-bot
chore(release): NO-JIRA dialtone-vue2/v2.167.1
7884659 
## [2.167.1](dialtone-vue2/v2.167.0...dialtone-vue2/v2.167.1) (2024-12-10)

### Code Refactoring

* DLT-2122 move css out of recipes ([#577](#577)) ([75d5a0b](75d5a0b))

### Documentation

* DLT-1799 move SB to docs - Tabs to Validation Messages ([#565](#565)) ([e78aece](e78aece))
braddialpad pushed a commit that referenced this pull request Dec 10, 2024
@semantic-release-bot
chore(release): NO-JIRA dialtone-vue3/v3.160.1
14d997a 
## [3.160.1](dialtone-vue3/v3.160.0...dialtone-vue3/v3.160.1) (2024-12-10)

### Code Refactoring

* DLT-2122 move css out of recipes ([#577](#577)) ([75d5a0b](75d5a0b))

### Documentation

* DLT-1799 move SB to docs - Tabs to Validation Messages ([#565](#565)) ([e78aece](e78aece))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braddialpad braddialpad braddialpad approved these changes

@juliodialpad juliodialpad Awaiting requested review from juliodialpad juliodialpad is a code owner

@iropolo iropolo Awaiting requested review from iropolo iropolo is a code owner

@francisrupert francisrupert Awaiting requested review from francisrupert francisrupert is a code owner

Assignees
No one assigned
Labels
no-visual-test Add this tag when the PR does not need visual testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ninamarina @braddialpad