Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: NO-JIRA fix broken links #572

Merged
merged 5 commits into from
Nov 28, 2024
Merged

docs: NO-JIRA fix broken links #572

merged 5 commits into from
Nov 28, 2024

Conversation

juliodialpad
Copy link
Collaborator

@juliodialpad juliodialpad commented Nov 26, 2024

Fix broken links

Obligatory GIF (super important!)

Obligatory GIF

🛠️ Type Of Change

These types will not increment the version number, but will still deploy to documentation site on release:

  • Documentation

📖 Jira Ticket

No Jira ticket

📖 Description

Fixed a bunch of broken links

💡 Context

I was receiving Algolia Crawler reports often and haven't paid a lot attention until today and realized that we have too many broken links on our doc site. Fixed most of them but some others have a strange query string that I don't know where's coming from. I'll check that after this is merged and a new crawl has been done.

📝 Checklist

For all PRs:

  • I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
  • I have reviewed my changes.

🔮 Next Steps

Re-run crawl to check that we have no broken links.

📷 Screenshots / GIFs

image

🔗 Sources

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>
@juliodialpad juliodialpad added the no-visual-test Add this tag when the PR does not need visual testing label Nov 26, 2024
@juliodialpad juliodialpad self-assigned this Nov 26, 2024
Copy link
Contributor

@braddialpad braddialpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, more broken links than I realized.

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>
Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>
@juliodialpad
Copy link
Collaborator Author

Found a lot more issues while checking that everything was OK, please give it another review round.

Went through every page and checked every link, missing data, images, etc... fixed everything that I could find.

Copy link

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-572/

Copy link
Contributor

@braddialpad braddialpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recent changes look good, thanks!

@juliodialpad juliodialpad merged commit 98038c0 into staging Nov 28, 2024
6 checks passed
@juliodialpad juliodialpad deleted the docs/fix-broken-links branch November 28, 2024 23:23
braddialpad pushed a commit that referenced this pull request Dec 5, 2024
## [9.86.1](dialtone/v9.86.0...dialtone/v9.86.1) (2024-12-03)

### Bug Fixes

* **Tokens:** DLT-1961 output font related tokens as rem instead of px ([#576](#576)) ([7241f65](7241f65))

### Documentation

* DLT-1799 move SB to docs - Tabs to Validation Messages ([#565](#565)) ([e78aece](e78aece))
* NO-JIRA fix broken links ([#572](#572)) ([98038c0](98038c0))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-visual-test Add this tag when the PR does not need visual testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants