Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nats-streaming] Release v0.23.2 #2084

Merged
merged 2 commits into from
Nov 20, 2021
Merged

[nats-streaming] Release v0.23.2 #2084

merged 2 commits into from
Nov 20, 2021

Conversation

kozlovic
Copy link
Contributor

Details can be found here

Signed-off-by: Ivan Kozlovic ivan@synadia.com

@kozlovic
[nats-streaming] Release v0.23.2
40b93d6 
Details can be found [here](https://github.com/nats-io/nats-streaming-server/releases/tag/v0.23.2)

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@kozlovic kozlovic mentioned this pull request Nov 19, 2021
Merged
@tianon
Copy link
Member

tianon commented Nov 19, 2021

I would suggest two things:

  • if you put this in a deprecated.md, it'll show up at the very very top of the description (increasing visibility):

    docs/update.sh

    Lines 107 to 112 in 8221c80

    deprecated=
    if [ -f "$repo/deprecated.md" ]; then
    deprecated=$'# **DEPRECATION NOTICE**\n\n'
    deprecated+="$(cat "$repo/deprecated.md")"
    deprecated+=$'\n\n'
    fi
  • I would also recommend adding DEPRECATED; to the beginning of readme-short.txt so that the status is clear to users directly in docker search and the Hub search interface/views

@kozlovic kozlovic force-pushed the nats_streaming_0_23_2 branch from dd43476 to 181d253 Compare November 20, 2021 00:03
@kozlovic
Copy link
Contributor Author

@tianon Hum... trying to add DEPRECATED; as you suggested, but get a failure.. I tried first on the same line, got a failure, so made a new line, still failure..

@kozlovic
Updates based on review
1d7088a 
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@kozlovic kozlovic force-pushed the nats_streaming_0_23_2 branch from 181d253 to 1d7088a Compare November 20, 2021 00:08
@tianon tianon merged commit d204a2f into docker-library:master Nov 20, 2021
@kozlovic kozlovic deleted the nats_streaming_0_23_2 branch November 22, 2021 16:37
yosifkit added a commit to infosiftr/stackbrew that referenced this pull request Jun 17, 2024
@yosifkit
Remove tags from deprecated images
2972653 
- `consul`: docker-library/docs#2283
- `express-gateway`: docker-library/docs#2138
- `jobber`: docker-library/docs#2148
- `nats-streaming`: docker-library/docs#2084
- `vault`: docker-library/docs#2291
@yosifkit yosifkit mentioned this pull request Jun 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianon tianon tianon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kozlovic @tianon