Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation notice to Vault #2291

Merged
merged 3 commits into from
Mar 10, 2023
Merged

Conversation

mladlow
Copy link
Contributor

@mladlow mladlow commented Mar 7, 2023

I'd like to update our docker image docs to warn about an impending switch to publishing only the Verified Publisher images per a deprecation notice here: https://developer.hashicorp.com/vault/docs/deprecation.

I've also gotten the Verified Publisher documentation (https://hub.docker.com/r/hashicorp/vault) updated though it doesn't have all the fancy updates from the update script.

* Update content.md

* fix markdownfmt
@tianon
Copy link
Member

tianon commented Mar 8, 2023

This should probably match #2283, right? 😅
(esp. the bits about using our deprecated.md functionality to make this more prominent 👀)

I'd also very explicitly echo my comment from #2283 (comment): ❤️

We're sorry to see you go, and our door is definitely open for helping however we can to bring these back or continue to keep them in DOI as well, but we totally understand that from a publisher perspective this is difficult to maintain in multiple places/pipelines. 🙇 ❤️

@tianon tianon changed the title Switch to Verified Publisher images Add deprecation notice to Vault Mar 8, 2023
@mladlow
Copy link
Contributor Author

mladlow commented Mar 8, 2023

@tianon I will update this. It will take me longer than I want. Thank you for the thoughts and kind words! The multiple pipelines has become fairly difficult to maintain.

@@ -0,0 +1,2 @@
Upcoming in Vault 1.14, we will stop publishing official Dockerhub images and publish only our Verified Publisher images. Users of Docker images should pull from [hashicorp/vault](https://hub.docker.com/r/hashicorp/vault) instead of [vault](https://hub.docker.com/_/vault). Verified Publisher images can be found at https://hub.docker.com/r/hashicorp/vault.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

I think this is all the CI is complaining about 😅

(I'm happy to take care of this change if you'd rather or that would be helpful 🙇)

@tianon tianon merged commit fa77237 into docker-library:master Mar 10, 2023
yosifkit added a commit to infosiftr/stackbrew that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants