Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hashicorp/consul] Add deprecation notice #2283

Merged
merged 4 commits into from
Mar 3, 2023

Conversation

mdeggies
Copy link
Contributor

Adds an official image deprecation notice/warning for consul, and points end users to the verified publisher images at hashicorp/consul.

If there is another way to add a deprecation notice, or other files that should be updated in this PR, please let me know! :)

Adds an official image deprecation notice/warning, and points end users to the verified publisher images at hashicorp/consul.
@yosifkit
Copy link
Member

We have code for a deprecated.md that will ensure it gets put at the top of the Docker Hub page content. Like openjdk deprecated.md as seen in the generated README.md and on Docker Hub.

Is there a timeline for the 1.16 release? As I understand this wording, 1.15.* will be added to the official images, but 1.16.* will not. Will the 1.14 and 1.15 release series still be updated in official images after the 1.16 transition? Do you want us to delete the latest tag once 1.16 is released (and the library/consul updated to not reference a latest tag)?

@david-yu
Copy link

david-yu commented Feb 24, 2023

Hi @yosifkit our plan is to stop producing any patches for any releases (including 1.15.x, 1.14.x) at the time 1.16.0 will GA. This will be roughly 4 months from now in June 2023.

@mdeggies
Copy link
Contributor Author

Thanks @yosifkit! I just updated the PR.

At the time 1.16 is released, it would be great to make those additional updates you mentioned (deleting the latest tag and updating references to it) to nudge users to adopt the verified publisher images instead. Let me know where we can put in a request for this!

@yosifkit
Copy link
Member

yosifkit commented Mar 1, 2023

To have a us delete specific tags from Docker Hub, just include a github comment in the PR that updates the library/consul file that removes those tags from official images. (https://github.com/docker-library/official-images/pulls?q=is%3Apr+label%3Alibrary%2Fconsul)

@mdeggies
Copy link
Contributor Author

mdeggies commented Mar 1, 2023

Got it, we will be sure to do this in June at the time of the 1.16 release. Thanks for all your help!

@mdeggies
Copy link
Contributor Author

mdeggies commented Mar 1, 2023

Let me know if there are any other todo's prior to merging, and thanks again!

@tianon
Copy link
Member

tianon commented Mar 3, 2023

We're sorry to see you go, and our door is definitely open for helping however we can to bring these back or continue to keep them in DOI as well, but we totally understand that from a publisher perspective this is difficult to maintain in multiple places/pipelines. 🙇 ❤️

@tianon tianon merged commit d19f551 into docker-library:master Mar 3, 2023
@mdeggies mdeggies deleted the patch-1 branch March 7, 2023 18:52
mladlow added a commit to hashicorp/docker-docs that referenced this pull request Mar 9, 2023
tianon pushed a commit that referenced this pull request Mar 10, 2023
yosifkit added a commit to infosiftr/stackbrew that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants