Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove latest tag for official Consul images #14949

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

nathancoleman
Copy link
Contributor

@nathancoleman nathancoleman commented Jun 27, 2023

In alignment with docker-library/docs#2283 and #14940, we'd like to:

  • remove the latest tag here for consul
  • request that the existing latest tag be deleted

@github-actions
Copy link

Diff for 115545b:
diff --git a/_bashbrew-cat b/_bashbrew-cat
index 36b1d3d..0a601a3 100644
--- a/_bashbrew-cat
+++ b/_bashbrew-cat
@@ -12,7 +12,7 @@ GitRepo: https://github.com/hashicorp/docker-consul.git
 GitCommit: 7c095b8e988517c239526c0137caeb837c490807
 Directory: 0.X
 
-Tags: 1.15.4, 1.15, latest
+Tags: 1.15.4, 1.15
 Architectures: amd64, arm32v6, arm64v8, i386
 GitRepo: https://github.com/hashicorp/docker-consul.git
 GitCommit: aedd0844f06e9eac9c4e130206219b1ff044a8c4
diff --git a/_bashbrew-list b/_bashbrew-list
index f366b60..99c6dd9 100644
--- a/_bashbrew-list
+++ b/_bashbrew-list
@@ -4,4 +4,3 @@ consul:1.14
 consul:1.14.8
 consul:1.15
 consul:1.15.4
-consul:latest
diff --git a/_bashbrew-list-build-order b/_bashbrew-list-build-order
index 367c4c2..89f59e6 100644
--- a/_bashbrew-list-build-order
+++ b/_bashbrew-list-build-order
@@ -1,3 +1,3 @@
 consul:1.13
 consul:1.14
-consul:latest
+consul:1.15
diff --git a/consul_latest/Dockerfile b/consul_1.15/Dockerfile
similarity index 100%
rename from consul_latest/Dockerfile
rename to consul_1.15/Dockerfile
diff --git a/consul_latest/docker-entrypoint.sh b/consul_1.15/docker-entrypoint.sh
similarity index 100%
rename from consul_latest/docker-entrypoint.sh
rename to consul_1.15/docker-entrypoint.sh

Relevant Maintainers:

  • consul: @hashicorp/consul

@nathancoleman
Copy link
Contributor Author

nathancoleman commented Jun 27, 2023

FYI @david-yu @jmurret

@tianon tianon merged commit b200eb0 into docker-library:master Jun 27, 2023
@tianon
Copy link
Member

tianon commented Jun 27, 2023

As requested:

$ docker pull consul:latest
Error response from daemon: manifest for consul:latest not found: manifest unknown: manifest unknown

🙇 ❤️

@nathancoleman
Copy link
Contributor Author

Thank you so much @tianon !

@nathancoleman nathancoleman deleted the consul-remove-latest branch June 27, 2023 22:20
@nathancoleman
Copy link
Contributor Author

For anyone arriving at this PR that might need it, please see the deprecation notice introduced in docker-library/docs#2283 which recommends pulling from hashicorp/consul:latest going forward.

@tianon
Copy link
Member

tianon commented Jun 28, 2023

To be certain you don't feel left out, I'll explicitly echo my comment from vault: We'll be here, ready to help if you ever decide you want to resurrect this image. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants