Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove latest tag from official Vault images #14940

Merged
merged 11 commits into from
Jun 26, 2023

Conversation

mladlow
Copy link
Contributor

@mladlow mladlow commented Jun 26, 2023

Per docker-library/docs#2283 (comment), could I also request that the latest tag be deleted please?

@mladlow mladlow changed the title Remove latest tag from official images Remove latest tag from official Vault images Jun 26, 2023
@github-actions
Copy link

Diff for dd9415d:
diff --git a/_bashbrew-cat b/_bashbrew-cat
index 70ce0a9..c56131b 100644
--- a/_bashbrew-cat
+++ b/_bashbrew-cat
@@ -12,7 +12,7 @@ Architectures: amd64, arm32v6, arm64v8, i386
 GitCommit: 48d258c844d65814e16c123f8d3750a4e73e4350
 Directory: 0.X
 
-Tags: 1.13.3, latest
+Tags: 1.13.3
 Architectures: amd64, arm32v6, arm64v8, i386
 GitCommit: 152f49d818b2764c437ee1fd20ee4d13791a8296
 Directory: 0.X
diff --git a/_bashbrew-list b/_bashbrew-list
index c8673bd..c3b01e3 100644
--- a/_bashbrew-list
+++ b/_bashbrew-list
@@ -1,4 +1,3 @@
 vault:1.11.11
 vault:1.12.7
 vault:1.13.3
-vault:latest
diff --git a/_bashbrew-list-build-order b/_bashbrew-list-build-order
index f6ab664..c3b01e3 100644
--- a/_bashbrew-list-build-order
+++ b/_bashbrew-list-build-order
@@ -1,3 +1,3 @@
 vault:1.11.11
 vault:1.12.7
-vault:latest
+vault:1.13.3
diff --git a/vault_latest/Dockerfile b/vault_1.13.3/Dockerfile
similarity index 100%
rename from vault_latest/Dockerfile
rename to vault_1.13.3/Dockerfile
diff --git a/vault_latest/docker-entrypoint.sh b/vault_1.13.3/docker-entrypoint.sh
similarity index 100%
rename from vault_latest/docker-entrypoint.sh
rename to vault_1.13.3/docker-entrypoint.sh

Relevant Maintainers:

@tianon tianon merged commit 4d2d1ef into docker-library:master Jun 26, 2023
@tianon
Copy link
Member

tianon commented Jun 26, 2023

As requested:

$ docker pull vault:latest
Error response from daemon: manifest for vault:latest not found: manifest unknown: manifest unknown

👍 ❤️

@drewfish
Copy link

I can see how this is a good idea, but FYI this was a surprise and broke my CI builds.

The latest tag appears to documented as officially supported:
Screen Shot 2023-06-26 at 15 16 22

@drewfish
Copy link

Ack... I just saw this notice... I will do as it suggets.

DEPRECATION NOTICE
Upcoming in Vault 1.14, we will stop publishing official Dockerhub images and publish only our Verified Publisher images. Users of Docker images should pull from hashicorp/vault instead of vault. Verified Publisher images can be found at https://hub.docker.com/r/hashicorp/vault.

@mladlow
Copy link
Contributor Author

mladlow commented Jun 27, 2023

Hey @drewfish I'm sorry this change broke your CI but glad that you can make the update. Thanks for adding the instructions here! I bet they will be helpful for future readers. Thanks @tianon for all your help over the years ❤️

@tianon
Copy link
Member

tianon commented Jun 27, 2023

For sure! We'll be here, ready to help if you ever decide you want to resurrect this image. ❤️

edigaryev added a commit to cirruslabs/cirrus-ci-agent that referenced this pull request Jul 1, 2023
edigaryev added a commit to cirruslabs/cirrus-ci-agent that referenced this pull request Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants