-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symfony 7 support #784
Symfony 7 support #784
Conversation
Also fixed the workflow - it wasn't properly setting Oi, this opened a can of worms as the bundle hasn't been properly tested by the CI since #678. |
fd30cbd
to
e5f3caf
Compare
Looks like it's installing |
Just merged #785, shall we release patch version, merge up, and rebase this PR? |
c9e5b76
to
f2b6fee
Compare
I need this to make api-platform Symfony7-ready |
@chalasr, yes, if you don't mind :) |
31dcab2
to
c969393
Compare
* | ||
* @return void | ||
*/ | ||
protected function loadDocumentManager(array $documentManager, $defaultDM, $defaultDB, ContainerBuilder $container) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* | |
* @return void | |
*/ | |
protected function loadDocumentManager(array $documentManager, $defaultDM, $defaultDB, ContainerBuilder $container) | |
*/ | |
protected function loadDocumentManager(array $documentManager, $defaultDM, $defaultDB, ContainerBuilder $container): void |
It would be nice to revisit later if protected
makes sense.
70395bc
to
9777b54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also remove this
DoctrineMongoDBBundle/DependencyInjection/DoctrineMongoDBExtension.php
Lines 403 to 406 in ddf39bb
// available in Symfony 6.2 and higher | |
if (! class_exists(EntityValueResolver::class)) { | |
return; | |
} |
"symfony/yaml": "^5.4 || ^6.2", | ||
"symfony/browser-kit": "^6.4 || ^7.0", | ||
"symfony/form": "^6.4 || ^7.0", | ||
"symfony/phpunit-bridge": "^6.4.1 || ^7.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"symfony/phpunit-bridge": "^6.4.1 || ^7.0.1", | |
"symfony/phpunit-bridge": "^7.0.1", |
I guess we can use only the latest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, both are almost identical. I don't want to conflict with the SYMFONY_REQUIRE=6.4.*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the CS job is failing
Thank you @kbond for starting this work. As you said, it wasn't as simple as it looked. |
Blockers: