Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llf: broken in VR due to eye desync #601

Closed
Tracked by #402
alandtse opened this issue Oct 7, 2024 · 2 comments · Fixed by #605 or #616
Closed
Tracked by #402

llf: broken in VR due to eye desync #601

alandtse opened this issue Oct 7, 2024 · 2 comments · Fixed by #605 or #616
Labels
bug Something isn't working

Comments

@alandtse
Copy link
Collaborator

alandtse commented Oct 7, 2024 •
edited
Loading

Caused by #506
@alandtse alandtse mentioned this issue Oct 7, 2024
Closed
55 tasks
@alandtse alandtse added the bug Something isn't working label Oct 7, 2024
@alandtse
Copy link
Collaborator Author

alandtse commented Oct 7, 2024

Initial review seems to be caused by

skyrim-community-shaders/package/Shaders/Lighting.hlsl

Lines 2134 to 2136 in e3f9d96

if ((PixelShaderDescriptor & _DefShadow) && (light.lightFlags & Llf_ShadowLight)) {
shadowComponent = shadowColor[light.shadowLightIndex];
lightShadow *= shadowComponent;

The shadowComponent is not matching.

@alandtse alandtse mentioned this issue Oct 7, 2024
Merged
@alandtse alandtse reopened this Oct 7, 2024
@alandtse
Copy link
Collaborator Author

alandtse commented Oct 7, 2024

PR reverted since it seems to hurt flat

alandtse added a commit to alandtse/skyrim-community-shaders that referenced this issue Oct 8, 2024
@alandtse
fix: fix shadows in LLF
b9289cf 
closes doodlum#601
alandtse added a commit to alandtse/skyrim-community-shaders that referenced this issue Oct 8, 2024
@alandtse
fix(VR): fix VR desync
958bc9a 
closes doodlum#601
alandtse added a commit to alandtse/skyrim-community-shaders that referenced this issue Oct 8, 2024
@alandtse
fix(VR): fix VR desync
8f66e5d 
closes doodlum#601
@alandtse alandtse mentioned this issue Oct 8, 2024
Closed
alandtse added a commit to alandtse/skyrim-community-shaders that referenced this issue Oct 9, 2024
@alandtse
fix(VR): fix llf desync in eyes
d31db42 
Updates commonlibng to latest with correct RE for VR in BSShadowLight.

closes doodlum#601
alandtse added a commit to alandtse/skyrim-community-shaders that referenced this issue Oct 9, 2024
@alandtse
fix(VR): fix llf desync in eyes
91894b2 
Updates commonlibng to latest with correct RE for VR in BSShadowLight.

closes doodlum#601
@alandtse alandtse mentioned this issue Oct 9, 2024
Merged
alandtse added a commit to alandtse/skyrim-community-shaders that referenced this issue Oct 9, 2024
@alandtse
fix(VR): fix VR desync
ef1915c 
closes doodlum#601
alandtse added a commit to alandtse/skyrim-community-shaders that referenced this issue Oct 9, 2024
@alandtse
fix(VR): fix llf desync in eyes
2c14dfc 
Updates commonlibng to latest with correct RE for VR in BSShadowLight.

closes doodlum#601
alandtse added a commit that referenced this issue Oct 9, 2024
@alandtse
fix(VR): fix llf desync in eyes (#616)
93f1054 
closes #601
alandtse added a commit to alandtse/skyrim-community-shaders that referenced this issue Oct 9, 2024
@alandtse
fix(VR): fix VR desync
f3714c1 
closes doodlum#601
alandtse added a commit to alandtse/skyrim-community-shaders that referenced this issue Oct 9, 2024
@alandtse
fix(VR): fix VR desync
95a4a23 
closes doodlum#601
alandtse added a commit to alandtse/skyrim-community-shaders that referenced this issue Oct 10, 2024
@alandtse
fix(VR): fix VR desync
4111280 
closes doodlum#601
doodlum pushed a commit that referenced this issue Oct 10, 2024
@alandtse
feat(VR): enable volumetric lighting (#565)
2fb12d0 
* feat(VR): enable volumetric lighting

* fix: fix stereo access to VLTex

VLTex is still mono and causes artifacts, but this is a correct step
once it is stereo.
#565 (comment)

* fix: fix stereouv access

* fix: fix WindInput

* feat: add initial RE for ISFullScreenVR

* fix: fix previous depth calculation in dynres

The depth stencil from ISDepthBufferCopy is actually full size and not
scaled with dynres enabled.

* feat: add dynres status to state

* fix: fix dynres for volumetric lighting

* chore: fix typo

* fix: require vr address library 0.154.0

* fix: fix crash of shizof mods at dataloaded

* revert: "feat: add dynres status to state"

This reverts commit c3658ad.

* fix: use Util::IsDynamicResolution

* fix: fix improper depth size when downsampled

* fix: fix bad rendering with bDepthBufferCulling

With bDepthBufferCulling enabled, culling is incorrect if diskcache is
on until ShaderCache is cleared. This is a stopgap until root cause is
identified.

* fix(VR): fix VR desync

closes #601

* revert: "fix(VR): fix VR desync"

This reverts commit 958bc9a.

* style: 🎨 apply clang-format changes

* style: fix doxygen spacing

* refactor: use new namespaces

* fix: fix VR namespace define conflict

* chore: remove unused vr code

* refactor: fix flat compile errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@alandtse