feat(VR): enable volumetric lighting #565

alandtse · 2024-09-28T10:09:19Z

Ready to merge after prereqs.

Testing for new bugs.

Known bugs

bUseHiddenAreaMesh disabled has bad stencil. - Not reproducible on Quest 3. Looks fine for my testing.
PureDark upscaler ultra performance results in flickering (likely won't fix)
Disabling dynamic resolution results in bad stencil at edges of eyes. Restart after making this change. (likely won't fix)

VLTex is still mono and causes artifacts, but this is a correct step once it is stereo. doodlum#565 (comment)

alandtse · 2024-09-30T23:30:28Z

No biggie. The improvements were marginal and honestly not something that is too important to me. My rebase should have removed them but I'll verify again.

VLTex is still mono and causes artifacts, but this is a correct step once it is stereo. doodlum#565 (comment)

alandtse · 2024-10-04T08:58:34Z

Dynres is fixed.

alandtse · 2024-10-04T09:24:46Z

package/Shaders/ISApplyVolumetricLighting.hlsl

@@ -48,14 +57,25 @@ PS_OUTPUT main(PS_INPUT input)
 		float2 previousTexCoord = input.TexCoord + motionVector;
 		float2 previousScreenPosition = GetPreviousDynamicResolutionAdjustedScreenPosition(previousTexCoord);
 		float previousVl = PreviousFrameTex.Sample(PreviousFrameSampler, previousScreenPosition).x;
-		float previousDepth = PreviousDepthTex.Sample(PreviousDepthSampler, previousScreenPosition).x;
+		float previousDepth = PreviousDepthTex.Sample(PreviousDepthSampler,
+#	ifndef VR


This also may be a flat bug, but I didn't check since dynres isn't toggleable in the gui.

VLTex is still mono and causes artifacts, but this is a correct step once it is stereo. doodlum#565 (comment)

Moyse06 · 2024-10-05T03:27:56Z

Night sky has a lot of flickers. Has been this way since August I believe.

alandtse · 2024-10-05T04:29:03Z

Not related to VL.

alandtse · 2024-10-05T09:50:39Z

I'm actually thinking there's no reason to do the CopyResources call. Right now by trying to restore the call when not in dyn res, I'm seeing some tearing as the stencil size actually changes in phases resulting in some artifacts if you're toggling dynres. Looking at renderdoc, I don't see any reason to keep the CopyResources call (which actually was the effect of earlier builds due to a bad boolean check).

EDIT: One reason discovered, bDepthBufferCulling and no dynres results in no depth buffer being generated anywhere in the frame. The copy is required to generate something so the previousframe depth buffer is correct.

VLTex is still mono and causes artifacts, but this is a correct step once it is stereo. doodlum#565 (comment)

alandtse · 2024-10-06T07:05:40Z

Fixed bDepthBufferCulling bugs:

Downscaled depth buffer stencil resulting in bad UI stencil
Rendering objects improperly culled with disk cache enabled

VLTex is still mono and causes artifacts, but this is a correct step once it is stereo. doodlum#565 (comment)

package/Shaders/ISApplyVolumetricLighting.hlsl

VLTex is still mono and causes artifacts, but this is a correct step once it is stereo. doodlum#565 (comment)

The depth stencil from ISDepthBufferCopy is actually full size and not scaled with dynres enabled.

This reverts commit c3658ad.

With bDepthBufferCulling enabled, culling is incorrect if diskcache is on until ShaderCache is cleared. This is a stopgap until root cause is identified.

closes doodlum#601

This reverts commit 958bc9a.

alandtse · 2024-10-10T02:58:44Z

Can't reproduce any bug with bUseHiddenAreaMesh. Looks like a hmd specific bug with upscaler.

alandtse force-pushed the vr_vl branch 2 times, most recently from 754a2c2 to 7f8e9c2 Compare September 29, 2024 02:51

This comment was marked as outdated.

Sign in to view

alandtse force-pushed the vr_vl branch from 7f8e9c2 to fad1db5 Compare September 30, 2024 00:39

alandtse added a commit to alandtse/skyrim-community-shaders that referenced this pull request Sep 30, 2024

fix: fix stereo access to VLTex

e835ac6

VLTex is still mono and causes artifacts, but this is a correct step once it is stereo. doodlum#565 (comment)

This comment was marked as resolved.

Sign in to view

alandtse added a commit to alandtse/skyrim-community-shaders that referenced this pull request Oct 2, 2024

fix: fix stereo access to VLTex

0a3ad54

VLTex is still mono and causes artifacts, but this is a correct step once it is stereo. doodlum#565 (comment)

alandtse force-pushed the vr_vl branch from e8725af to 171aa20 Compare October 2, 2024 07:17

alandtse marked this pull request as ready for review October 4, 2024 09:05

alandtse commented Oct 4, 2024

View reviewed changes

alandtse added a commit to alandtse/skyrim-community-shaders that referenced this pull request Oct 4, 2024

fix: fix stereo access to VLTex

b2d1627

VLTex is still mono and causes artifacts, but this is a correct step once it is stereo. doodlum#565 (comment)

alandtse force-pushed the vr_vl branch from 19fcd3c to 6b47258 Compare October 4, 2024 09:35

This comment was marked as resolved.

Sign in to view

alandtse marked this pull request as draft October 5, 2024 04:38

alandtse marked this pull request as ready for review October 5, 2024 05:25

This comment was marked as outdated.

Sign in to view

alandtse added a commit to alandtse/skyrim-community-shaders that referenced this pull request Oct 5, 2024

fix: fix stereo access to VLTex

e04315e

VLTex is still mono and causes artifacts, but this is a correct step once it is stereo. doodlum#565 (comment)

alandtse force-pushed the vr_vl branch from f737da2 to 7391596 Compare October 5, 2024 20:30

alandtse force-pushed the vr_vl branch from f293518 to fd74a35 Compare October 6, 2024 10:20

alandtse added a commit to alandtse/skyrim-community-shaders that referenced this pull request Oct 6, 2024

fix: fix stereo access to VLTex

a57779c

VLTex is still mono and causes artifacts, but this is a correct step once it is stereo. doodlum#565 (comment)

alandtse added a commit to alandtse/skyrim-community-shaders that referenced this pull request Oct 6, 2024

fix: fix stereo access to VLTex

d3634af

VLTex is still mono and causes artifacts, but this is a correct step once it is stereo. doodlum#565 (comment)

alandtse force-pushed the vr_vl branch from fd74a35 to f2b6fc8 Compare October 6, 2024 23:23

alandtse added a commit to alandtse/skyrim-community-shaders that referenced this pull request Oct 9, 2024

fix: fix stereo access to VLTex

ddf267e

VLTex is still mono and causes artifacts, but this is a correct step once it is stereo. doodlum#565 (comment)

alandtse force-pushed the vr_vl branch from 1f16da8 to 3645674 Compare October 9, 2024 09:10

FlayaN reviewed Oct 9, 2024

View reviewed changes

package/Shaders/ISApplyVolumetricLighting.hlsl Outdated Show resolved Hide resolved

FlayaN approved these changes Oct 9, 2024

View reviewed changes

alandtse and others added 21 commits October 9, 2024 19:44

feat(VR): enable volumetric lighting

1e67cbc

fix: fix stereo access to VLTex

1252e12

VLTex is still mono and causes artifacts, but this is a correct step once it is stereo. doodlum#565 (comment)

fix: fix stereouv access

b4c6b54

fix: fix WindInput

9d44deb

feat: add initial RE for ISFullScreenVR

7301acb

fix: fix previous depth calculation in dynres

3e0f348

The depth stencil from ISDepthBufferCopy is actually full size and not scaled with dynres enabled.

feat: add dynres status to state

b9ed50a

fix: fix dynres for volumetric lighting

c2144b5

chore: fix typo

97063be

fix: require vr address library 0.154.0

8c5c39f

fix: fix crash of shizof mods at dataloaded

85abec4

revert: "feat: add dynres status to state"

d7ab4c9

This reverts commit c3658ad.

fix: use Util::IsDynamicResolution

8af2064

fix: fix improper depth size when downsampled

0bbed17

fix: fix bad rendering with bDepthBufferCulling

bf21188

With bDepthBufferCulling enabled, culling is incorrect if diskcache is on until ShaderCache is cleared. This is a stopgap until root cause is identified.

fix(VR): fix VR desync

4111280

closes doodlum#601

revert: "fix(VR): fix VR desync"

2170f68

This reverts commit 958bc9a.

style: 🎨 apply clang-format changes

060b21b

style: fix doxygen spacing

7e55566

refactor: use new namespaces

167a146

fix: fix VR namespace define conflict

c358ba4

alandtse force-pushed the vr_vl branch from 3645674 to c358ba4 Compare October 10, 2024 02:44

chore: remove unused vr code

565d055

refactor: fix flat compile errors

5b7faf4

doodlum merged commit 2fb12d0 into doodlum:dev Oct 10, 2024
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(VR): enable volumetric lighting #565

feat(VR): enable volumetric lighting #565

alandtse commented Sep 28, 2024 •

edited

Loading

This comment was marked as outdated.

This comment was marked as resolved.

This comment was marked as resolved.

alandtse commented Sep 30, 2024

alandtse commented Oct 4, 2024

alandtse Oct 4, 2024

This comment was marked as resolved.

This comment was marked as resolved.

Moyse06 commented Oct 5, 2024 •

edited

Loading

alandtse commented Oct 5, 2024

This comment was marked as outdated.

alandtse commented Oct 5, 2024 •

edited

Loading

alandtse commented Oct 6, 2024 •

edited

Loading

alandtse commented Oct 10, 2024

feat(VR): enable volumetric lighting #565

feat(VR): enable volumetric lighting #565

Conversation

alandtse commented Sep 28, 2024 • edited Loading

This comment was marked as outdated.

This comment was marked as resolved.

This comment was marked as resolved.

alandtse commented Sep 30, 2024

alandtse commented Oct 4, 2024

alandtse Oct 4, 2024

Choose a reason for hiding this comment

This comment was marked as resolved.

This comment was marked as resolved.

Moyse06 commented Oct 5, 2024 • edited Loading

alandtse commented Oct 5, 2024

This comment was marked as outdated.

alandtse commented Oct 5, 2024 • edited Loading

alandtse commented Oct 6, 2024 • edited Loading

alandtse commented Oct 10, 2024

alandtse commented Sep 28, 2024 •

edited

Loading

Moyse06 commented Oct 5, 2024 •

edited

Loading

alandtse commented Oct 5, 2024 •

edited

Loading

alandtse commented Oct 6, 2024 •

edited

Loading