feat: Use parallax in landscape texture blending #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ePagi/skyrim-community-shaders into terrain_parallax_blending_new
|
do total = rcp(total) instead of division since it's slow, and add [unroll] where applicable |
Pentalimbed
reviewed
Jul 14, 2024
features/Extended Materials/Shaders/ExtendedMaterials/ExtendedMaterials.hlsli
Outdated
Show resolved
Hide resolved
Pentalimbed
reviewed
Jul 14, 2024
| height = TexColorSampler.SampleLevel(SampTerrainParallaxSampler, coords, mipLevels[0]).w * input.LandBlendWeights1.x; | ||
| pixelOffset[0] = pow(input.LandBlendWeights1.x, 1 + 1 * blendFactor) * (pow(TexColorSampler.SampleLevel(SampTerrainParallaxSampler, coords, mipLevels[0]).w, blendFactor * HEIGHT_POWER)); | ||
| else | ||
| pixelOffset[0] = 0; |
There was a problem hiding this comment.
Same above, instead of branching here initialize the whole pixelOffset array to zero beforehand and save some elses. Or use inout on the argument since it is already initialised outside the function.
There was a problem hiding this comment.
Made it a bit nicer. Idk if there is a faster way to zero-initialize, but I can't leave old values there with inout, otherwise they will be used when weight is 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small change in the blending weights of landscape textures, makes details pop out more and make it feel more like distinct materials than a linear blend. Performance impact should be minimal.