Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix Lighting.hlsl warnings #643

Merged
merged 2 commits into from
Oct 14, 2024
Merged

fix: fix Lighting.hlsl warnings #643

merged 2 commits into from
Oct 14, 2024

Conversation

Pentalimbed
Copy link
Collaborator

part of #534

@alandtse
Copy link
Collaborator

alandtse commented Oct 14, 2024

Did you build with disk cache to find all warnings? I'm seeing the following (but maybe it's VR only).

E:\SteamLibrary\steamapps\common\SkyrimVR\Data\Shaders\Lighting.hlsl(1956,3-90): warning X3206: implicit truncation of vector type
E:\SteamLibrary\steamapps\common\SkyrimVR\Data\Shaders\Lighting.hlsl(2355,38-85): warning X3571: pow(f, e) will not work for negative f, use abs(f) or conditionally handle negative values if you expect them

and also

E:\SteamLibrary\steamapps\common\SkyrimVR\Data\Shaders\Lighting.hlsl(1918,22-124): warning X3206: 'ScreenSpaceShadows::GetScreenSpaceShadow': implicit truncation of vector type
E:\SteamLibrary\steamapps\common\SkyrimVR\Data\Shaders\Lighting.hlsl(1956,3-90): warning X3206: implicit truncation of vector type
E:\SteamLibrary\steamapps\common\SkyrimVR\Data\Shaders\Lighting.hlsl(2355,38-85): warning X3571: pow(f, e) will not work for negative f, use abs(f) or conditionally handle negative values if you expect them
E:\SteamLibrary\steamapps\common\SkyrimVR\Data\Shaders\Lighting.hlsl(1008,14): warning X3578: Output value 'main' is not completely initialized

I'm running just this PR so maybe you fixed it with #642?

Also, I didn't test it in game specifically for the effect but I'm ok with solving that later too.

@Pentalimbed
Copy link
Collaborator Author

One of them is fixed by #642 yes

As for pow, I want to fix all of them together by replacing them with a safe pow function, but I don't know where best to put the definition.

@doodlum doodlum merged commit 0be61e6 into doodlum:dev Oct 14, 2024
3 checks passed
@Pentalimbed Pentalimbed deleted the dev-3 branch October 14, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants