Fix #25917: Template Builder file containers were saving with Identifier instead of Path #25920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zJaaal
requested review from
fmontes,
rjvelazco,
manuelrojas and
hmoreras
and removed request for
fmontes
…rs-are-not-getting-saved-correctly
fmontes
requested changes
Aug 28, 2023
core-web/libs/template-builder/src/lib/components/template-builder/utils/gridstack-utils.ts
Outdated
Show resolved
Hide resolved
...eb/libs/template-builder/src/lib/components/template-builder/store/template-builder.store.ts
Outdated
Show resolved
Hide resolved
fmontes
approved these changes
Aug 28, 2023
…rs-are-not-getting-saved-correctly
rjvelazco
approved these changes
Aug 28, 2023
hmoreras
approved these changes
Aug 29, 2023
…rs-are-not-getting-saved-correctly
|
SonarQube Quality Gate
|
fmontes
deleted the
issue-25917-template-builder-file-containers-are-not-getting-saved-correctly
branch
fmontes
pushed a commit
that referenced
this pull request
Aug 31, 2023
…ier instead of Path (#25920) * dev (gridstack utils): add getContainerReference * dev (template builder store): implement getContainerReference * fix (palette content type module): add DotMessagePipe import * feedback (template builder): moved getContainerReference from utils to box component * feedback (template builder box test): enhance testing * fix (containers mock): fix merge errors
fmontes
added a commit
that referenced
this pull request
Aug 31, 2023
* Fix #25917: Template Builder file containers were saving with Identifier instead of Path (#25920) * dev (gridstack utils): add getContainerReference * dev (template builder store): implement getContainerReference * fix (palette content type module): add DotMessagePipe import * feedback (template builder): moved getContainerReference from utils to box component * feedback (template builder box test): enhance testing * fix (containers mock): fix merge errors * Fix #25937: Template Builder Enhancing error and request handling (#25942) * fix (template save and publish): enhancing error and request handling * feedback (dot templates service): delete old save and publish * fix (gridstack utils): EMPTY_ROWS_VALUE was being modified by reference * Fix #25926: Template Builder fixing wrong classes deletion (#25928) * dev (add style classes module): refactor to support remove any class * fix (template builder story): console error due to missing import * Fix #25926 Reimplement the autocomplete component (#25935) * Reimplement the autocomplete component * dev (add styles autocomplete): enhance functionality * Fix filtering and styling. * Fix the filtering and language messages * Add tests for JsonClassesService * Test are not running * fix (add styles dialog): now tests are running * Fix tests * Update mocks --------- Co-authored-by: Jalinson Diaz <zjaaaldev@gmail.com> * Fix #25926 Templater Builder: Fixing link target * Fixing test (#25911) --------- Co-authored-by: Jalinson Diaz <zjaaaldev@gmail.com> Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com> Co-authored-by: Manuel Rojas <manuel.rojas.21@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at 0ffbb8f
Summary
📁🛠️🧪
The pull request adds support for file containers in the template builder. File containers are containers defined by a file path instead of an identifier. The pull request modifies several files to handle file containers consistently and adds tests and mock data for the new functionality.
Walkthrough
DotPipesModuleto use the correct alias (link)DotMessagePipeas a provider for theDotPaletteContentTypeModuleto translate content type labels (link)getContainerReferencefunction fromgridstack-utils.tsto the template builder store (link)getContainerReferencefunction to handle file containers in the store state (link, link, link, link, link)getContainerReferencefunction to thegridstack-utils.tsfile to return the identifier or path of a container based on its source (link, link)sourceandpathproperties to the container mocks in thedot-containers.mock.tsfile (link)addContainerfunction in thetemplate-builder.store.spec.tsfile to accept a container parameter (link)mockFileContainervariable to thetemplate-builder.store.spec.tsfile to test file containers (link)template-builder.store.spec.tsfile (link, link)getContainerReferencefunction in thegridstack-utils.spec.tsfile (link, link)Screenshots
Original
Screen.Recording.2023-08-28.at.4.17.11.PM.mov
Updated
Screen.Recording.2023-08-28.at.4.19.50.PM.mov