Fix #25926: Template Builder fixing wrong classes deletion #25928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-classes-deletion
fmontes
approved these changes
Aug 29, 2023
…-classes-deletion
…-classes-deletion
manuelrojas
approved these changes
Aug 29, 2023
|
SonarQube Quality Gate
|
hmoreras
approved these changes
Aug 29, 2023
fmontes
deleted the
issue-25926-templater-builder-fixing-wrong-classes-deletion
branch
fmontes
pushed a commit
that referenced
this pull request
Aug 31, 2023
fmontes
added a commit
that referenced
this pull request
Aug 31, 2023
* Fix #25917: Template Builder file containers were saving with Identifier instead of Path (#25920) * dev (gridstack utils): add getContainerReference * dev (template builder store): implement getContainerReference * fix (palette content type module): add DotMessagePipe import * feedback (template builder): moved getContainerReference from utils to box component * feedback (template builder box test): enhance testing * fix (containers mock): fix merge errors * Fix #25937: Template Builder Enhancing error and request handling (#25942) * fix (template save and publish): enhancing error and request handling * feedback (dot templates service): delete old save and publish * fix (gridstack utils): EMPTY_ROWS_VALUE was being modified by reference * Fix #25926: Template Builder fixing wrong classes deletion (#25928) * dev (add style classes module): refactor to support remove any class * fix (template builder story): console error due to missing import * Fix #25926 Reimplement the autocomplete component (#25935) * Reimplement the autocomplete component * dev (add styles autocomplete): enhance functionality * Fix filtering and styling. * Fix the filtering and language messages * Add tests for JsonClassesService * Test are not running * fix (add styles dialog): now tests are running * Fix tests * Update mocks --------- Co-authored-by: Jalinson Diaz <zjaaaldev@gmail.com> * Fix #25926 Templater Builder: Fixing link target * Fixing test (#25911) --------- Co-authored-by: Jalinson Diaz <zjaaaldev@gmail.com> Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com> Co-authored-by: Manuel Rojas <manuel.rojas.21@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at ae71fb8
Summary
🐛🧪♻️
This pull request improves the functionality and testing of the
AddStyleClassesDialogcomponent, which allows users to add style classes to a template. It fixes bugs in the component template and the storybook component, refactors the store class to use a common method for creating style class objects, and adds theidproperty to theStyleClassModelinterface and the related unit tests.Walkthrough
template-builder.component.stories.tsfor autocomplete component (link, link)Screenshots
Screen.Recording.2023-08-29.at.11.16.43.AM.mov