Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick template issues for pre release #25971

Merged
merged 6 commits into from
Aug 31, 2023
Merged

Cherry pick template issues for pre release #25971

merged 6 commits into from
Aug 31, 2023

Conversation

fmontes
Copy link
Member

@fmontes fmontes commented Aug 31, 2023

Proposed Changes

  • change 1
  • change 2

Checklist

  • Tests
  • Translations
  • Security Implications Contemplated (add notes if applicable)

Additional Info

** any additional useful context or info **

Screenshots

Original Updated
** original screenshot ** ** updated screenshot **

zJaaal and others added 5 commits August 31, 2023 12:05
@zJaaal @fmontes
Fix #25917: Template Builder file containers were saving with Identif…
8278b29 
…ier instead of Path (#25920)

* dev (gridstack utils): add getContainerReference

* dev (template builder store): implement getContainerReference

* fix (palette content type module): add DotMessagePipe import

* feedback (template builder): moved getContainerReference from utils to box component

* feedback (template builder box test): enhance testing

* fix (containers mock): fix merge errors
@zJaaal @fmontes
Fix #25937: Template Builder Enhancing error and request handling (#2…
509f73d 
…5942)

* fix (template save and publish): enhancing error and request handling

* feedback (dot templates service): delete old save and publish

* fix (gridstack utils): EMPTY_ROWS_VALUE was being modified by reference
@zJaaal @fmontes
Fix #25926: Template Builder fixing wrong classes deletion (#25928)
3e02dbd 
* dev (add style classes module): refactor to support remove any class

* fix (template builder story): console error due to missing import
@fmontes @zJaaal
Fix #25926 Reimplement the autocomplete component (#25935)
fb93718 
* Reimplement the autocomplete component

* dev (add styles autocomplete): enhance functionality

* Fix filtering and styling.

* Fix the filtering and language messages

* Add tests for JsonClassesService

* Test are not running

* fix (add styles dialog): now tests are running

* Fix tests

* Update mocks

---------

Co-authored-by: Jalinson Diaz <zjaaaldev@gmail.com>
@rjvelazco @fmontes
Fix #25926 Templater Builder: Fixing link target
a4fec3b
@dotcms-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fmontes fmontes merged commit 5df882d into pre-release Aug 31, 2023
18 of 19 checks passed
@fmontes fmontes deleted the cherry-pick-pre-release branch August 31, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zJaaal zJaaal zJaaal approved these changes

@rjvelazco rjvelazco Awaiting requested review from rjvelazco

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fmontes @zJaaal @rjvelazco @manuelrojas