Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Named Pipe] Check for pipe broken on WaitConnectionAsync #46182

Closed
wants to merge 25 commits into from
Closed

[Named Pipe] Check for pipe broken on WaitConnectionAsync #46182

wants to merge 25 commits into from

Conversation

simonferquel
Copy link
Contributor

#[Named Pipe] Check for pipe broken on WaitConnectionAsync

Description

According to https://learn.microsoft.com/en-us/dotnet/api/system.io.pipes.namedpipeserverstream.waitforconnection?view=net-7.0#system-io-pipes-namedpipeserverstream-waitforconnection, WaitConnectionAsync can throw IOException when a pipe is broken. I am unable to write a test reproducing it, but I have seen it happen in the wild under high load with Unity's custom named pipe transport.

Without this catch block, the server can unexpectedly stop accepting connections under high load.

@simonferquel
[Named Pipe] Check for pipe broken on WaitConnectionAsync
fa46bce 
According to https://learn.microsoft.com/en-us/dotnet/api/system.io.pipes.namedpipeserverstream.waitforconnection?view=net-7.0#system-io-pipes-namedpipeserverstream-waitforconnection,
WaitConnectionAsync can throw IOException when a pipe is broken. I am
unable to write a test reproducing it, but I have seen it happen in
the wild under high load with Unity's custom named pipe transport.

Without this catch block, the server can unexpectedly stop accepting connections
under high load.

Signed-off-by: Simon Ferquel <simon.ferquel@unity3d.com>
@ghost ghost added area-runtime community-contribution Indicates that the PR has been added by a community member labels Jan 20, 2023
@ghost
Copy link

ghost commented Jan 20, 2023

Thanks for your PR, @simonferquel. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

Youssef1313 and others added 10 commits January 20, 2023 09:30
@Youssef1313
Run test on Linux and Mac (dotnet#45642)
ed77f14 
* Run test on Linux and Mac

* Use `ReplaceLineEndings`

* Always use lf

* Different approach

* Revert

* Doc
@dougbu
Update milestone assignments for PRs (dotnet#46178)
7560737 
- rules would have assigned PRs to released milestones
  - note however that these rules don't presently seem to be working!!

nits:
- remove duplicate rule for release/6.0 PRs
- remove rule for release/3.1 PRs since the release is no EOL
@brunolins16
Making JsonOptions AOT/Trimmer-safe with EnsureJsonTrimmability swi…
40dd230 
…tch (dotnet#45886)

* Adding EnsureJsonTrimmability switch

* Set TypeResolver to null

* Removing RUC/RDC attributes

* Removing ProblemDetails.Extension RUC/RDC

* Adding Test remote execution support

* Adding jsonoptions tests

* Update ProblemDetails.cs

* Update HttpValidationProblemDetailsJsonConverter.cs
@wtgodbe
Skip Source Build for now (dotnet#46190)
c77deeb
@halter73
Remove now-redundant properties from AOT template (dotnet#46194)
9a79370
@BrennanConroy
string.Split to Span.Split (dotnet#46098)
ebbf5eb
@mkArtakMSFT
Workaround fabricbot addMielstone task issue (dotnet#46195)
8d6d88e 
It looks like the `addMilestone` task doesn't run when there is an existing milestone set.
Clearing milestone before setting it to avoid this issue
@ShreyasJejurkar @javiercn
feat : Add StringSyntax for regex parameters (dotnet#40589)
1078da9 
* feat : Add `StringSyntax` for regex parameters

* add missing using statement.

* addressed PR feedback

* Update RuleBuilder.cs

* removed usage from test utils

Co-authored-by: Javier Calvarro Nelson <jacalvar@microsoft.com>
@Nick-Stanton @SteveSandersonMS
Add DispatchExceptionAsync to ComponentBase (dotnet#46074)
9ec0753 
* Add DispatchExceptionAsync

* add testing

* Update src/Components/Components/src/ComponentBase.cs

Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>

* Remove ref since ComponentBase doesn't have access

* Simplify ErrorBoundary test cases

* API feedback: make RenderHandle.DispatchExceptionAsync internal

* Revert "API feedback: make RenderHandle.DispatchExceptionAsync internal"

This reverts commit c15f5fe.

* Add unit test

Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
@eerhardt
Allow minimal host to be created without default HostBuilder behavior (…
0a3a01b 
…dotnet#46040)

* Allow minimal host to be created without default HostBuilder behavior

This adds a new Hosting API to reduce startup and app size, and ensures the default behavior is NativeAOT compatible.

Fix dotnet#32485

* Use the new slim hosting API in the api template.

Refactor the WebHostBuilder classes to share more code.
JamesNK and others added 10 commits January 23, 2023 08:34
@JamesNK
Fix route syntax highlighting parameter color (dotnet#46208)
8714420
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
02635ec 
…117.5 (dotnet#46215)

[main] Update dependencies from dotnet/arcade
@Suchiman
Delete duplicate define (dotnet#46202)
ac52b4d 
The exact same thing exists 2 lines above that
@wtgodbe
Don't depend on source-build job while it isn't running (dotnet#46220)
7369057
@thaystg
[blazor][wasm][debug]Press alt-shift-d and open firefox debug tab att…
1a1ab56 
…ached to the blazor app (dotnet#46132)

* Press alt-shift-d and open firefox debug tab attached to the blazor app

* remove debugger.launch.

* removing unrelated changes

* Removing unnecessary changes on chrome debugging.

* addressing @mkArtakMSFT comments

* Addressing @mkArtakMSFT comments.

* Addressing Steve comments, adding a console.warning message and remove the beautiful message, removed the Newtonsoft from the send message, todo: remove the Newtonsoft from receive message.

* Completely removing newtonsoft usage as asked by steve.

* Change warning message.
@david-acker
Move Kestrel shared source to src\Shared (dotnet#46112)
3261139
@dependabot
[main] (deps): Bump src/submodules/googletest (dotnet#46214)
19e357b 
Bumps [src/submodules/googletest](https://github.com/google/googletest) from `356fc30` to `ec25eea`.
- [Release notes](https://github.com/google/googletest/releases)
- [Commits](google/googletest@356fc30...ec25eea)

---
updated-dependencies:
- dependency-name: src/submodules/googletest
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@surayya-MS
Added withServerTimeout and withKeepAliveInterval to HubConnectionBui…
0e51178 
…lder for java client (dotnet#46172)

* Added withServerTimeout and withKeepAliveInterval to HubConnectionBuilder for java client
@captainsafia
Implement RouteHandlerServices.Map and use in RequestDelegateGenerator (
c5a59c4 
dotnet#46180)

* Implement RouteHandlerServices.Map and use in RequestDelegateGenerator

* Tweak generated code

* Remove warnings from generated code

* Fix docstring for RouteHandlerServices.Map

* Add baseline tests and fix global:: issue

* Clean up generated code

* Add HTTP verb caching and fix usings

* Use FQN and remove GeneratedCode attribute
@marafiq
Enumerate paramnames on startup (dotnet#46086)
9a118ce 
Enumerate endpoint parameter names on startup instead of allocating a list.
@adityamandaleeka
Copy link
Member

@JamesNK PTAL

@JamesNK JamesNK requested review from a team, dougbu, wtgodbe and javiercn as code owners January 24, 2023 05:37
@JamesNK JamesNK mentioned this pull request Jan 24, 2023
Merged
@JamesNK
Copy link
Member

JamesNK commented Jan 24, 2023

Sorry, I pushed to your PR branch to add logging and bought in a bunch of other commits by accident. I can't force push to your branch to clean up. I've created a new PR with your changes - #46230

@JamesNK JamesNK closed this Jan 24, 2023
@build-analysis build-analysis bot mentioned this pull request Jan 24, 2023
Open
2 tasks
@amcasey amcasey added area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlesware area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Awaiting requested review from Tratcher

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@JamesNK JamesNK Awaiting requested review from JamesNK JamesNK is a code owner

@mgravell mgravell Awaiting requested review from mgravell mgravell is a code owner

@dougbu dougbu Awaiting requested review from dougbu

@wtgodbe wtgodbe Awaiting requested review from wtgodbe wtgodbe is a code owner

@javiercn javiercn Awaiting requested review from javiercn javiercn is a code owner

Assignees

@JamesNK JamesNK

Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlesware area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.