This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
Merge master to nmirror #5396
Merged
Merge master to nmirror #5396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com> Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Add Vector<T> to CoreLib. Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com> Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Fixes dotnet/corefx#26033 Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
…#16186) * Additional changes based on feedback (bounds checks) * Adding remaining bounds checks Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
* Implement castclass & isinst for wasm (#4510) Implement castclass and isinst opcodes in ILToWebAssemblyImporter by doing related function calls to methods in System.Runtime.TypeCast. Fix #4510 Add castclass & isinst test in HelloWasm. This includes three types of casting: * castclass/isinst to classes. * castclass/isinst to interfaces. * castclass/isinst to array types. For now, the second and third part of test is failing due to runtime implementation problems which should be further digged into.
* Enable wasm building on OSX. Upgrade libLLVM to 4.0.0 and LLVMSharp to 5.0.0 LLVM upgrade: Fix 'Use still stuck around after Def is destroyed' of the deleted basic blocks Add wasm support in runtest.sh Remove HelloWasm.csproj reference to .ilproj on non-windows OS because of dependency on ilasm Fix LinkNative target to execute correct commands for Unix wasm builds. Added support for building on Ubuntu 16.04.3 Update documentation on how to build WebAssembly.
- Sometimes after some number of wget attempts to download the building is interrupted. For example, it breaks by 80%. Signed-off-by: Petr Bred <bredpetr@gmail.com>
- Auto-detect if there is clang symlink and version is not specified - Remove hardcode clang version from msbuild file Signed-off-by: Petr Bred <bredpetr@gmail.com>
Switch rid to generic linux in most places and stop pretending that we are on ubuntu-14.04. ubuntu-14.04 is left just at the two places that still need it.
* Implement break opcode as llvm.debugtrap. In Emscripten, `llvm.debugtrap` is implemented as a round-trip call to `debugger;` statement JavaScript which will invoke debugger in browsers; and in LLVM it's implemented as `unreachable` instruction of WASM. This should be a better match than `llvm.trap` on `break` opcode semantics. Fix #4511 Set IsDebuggerPresent to TRUE in case of WASM. Although `Debugger._isDebuggerAttached` is not set, this modify itself will allow `Debugger.Break` to work. Add test in HelloWasm for `Debugger.Break`.
Merge nmirror to master
- Сompatibility checks for cross compilation - Removed "flags duplicates" workaround Signed-off-by: Petr Bred <bredpetr@gmail.com>
- fix #5093 Signed-off-by: Petr Bred <bredpetr@gmail.com>
* Update dependencies * Include System.Private.Xml from uapaot
* Pass /LIBPATH to linker Package [Microsoft.DotNet.ILCompiler v1.0.0-alpha-26207-01](https://dotnet.myget.org/feed/dotnet-core/package/nuget/Microsoft.DotNet.ILCompiler/1.0.0-alpha-26207-01) was failing to compile WebAPI app when using non-developer command prompt on Windows, because Kernel32.lib and friends weren't get located. Capturing those from vsvarsall environment in `findvsvarsall.bat` script and passing it to link.exe fixes the error and compiles WebAPI app successfully. * Update docs to reflect the behavior
* Add GetHRForLastWin32Error to CoreLib Marshal
Signed-off-by: Petr Bred <bredpetr@gmail.com>
Signed-off-by: Petr Bred <bredpetr@gmail.com>
* attempt to fix stacktrace getting printed twice * Fix some default parameter issues, and wrong commit from last commit * Fix build errors, switch call from Debug.Assert to new FailFast FCall * Fix signature to allow more types of exception title * cleanup * Addressing comments from PR * More PR comments * remove useless using * Address comments on GC hole and few naming changes Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
* Added String Overload Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
…ue) (#16250) * Making Unix and Windows FileStream Dispose behavior more consistent and throwing IO related exception only on Dispose(true) Fixes: #26734 * Commenting out SecurityException, also providing reason Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
…(#16284) Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
…#16283) Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
…dded Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
- #3278 - Enabled only for ARM32. When ObjWriter is remotely updated, it will be possible to completely remove this workaround for other archs. Signed-off-by: Petr Bred <bredpetr@gmail.com>
…eLogging events. (#16317) Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
…zation support (#16223) * Add ReadOnlySpan string-like StartsWith API with globalization support * Add ReadOnlySpan string-like EndsWith API with globalization support * Fix nits from PR feedback. * Address PR feedback * Add unsafe keyword in CompareInfo.Unix methods. * Address PR feedback and fix signature of Interop.Globalization.EndsWith * Code formatting cleanup as suggested by VS. * Revert "Code formatting cleanup as suggested by VS." This reverts commit 20931fbf1ae113c6acaa3a4b2c0789b46d7ab06b. * Creating Span specific methods and working around use of IsFastSort * Code cleanup * Improve performance by avoiding slicing and fix impl bug * Remove commented out code and revert some calls to FindString * Updating checks for Unix to mimic what IsFastSort does. * Add length checks and include IsFastSort check within the loop * Fix bounds checks to not include 0x80 * Call correct method when StringComparison is IgnoreCase. * Update exception type in string compare to remain consistent Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Ran the regression test I wrote for dotnet/coreclr#16381 and found CoreRT has a different bug around this.
* acces -> access * accesss -> access * acknowleges -> acknowledges * actitivy -> activity * Additonally -> Additionally * Activable -> Activatable * adjustting -> adjusting * Aggresive -> Aggressive * agressively -> aggressively * agressive -> aggressive * Aleady -> Already * alernate -> alternate * aligh -> align * Alloctor -> Allocator * allready -> already * Althought -> Although * Amonst -> Amongst * anthing -> anything * Anthyhing -> Anything * Aquired -> Acquired * aquire -> acquire * Architecure -> Architecture * Arthimatic -> Arithmetic * artiface -> artifact * artifical -> artificial * Arugment -> Argument * assigining -> assigning * atomicly -> atomically * auxillary -> auxiliary * avilability -> availability
Mirror changes from dotnet/coreclr
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
* String Create options overlaod * Minor Change * Feedback * validation on options * obsolete removed * Implementing Iserializable and removing ignorecase * HashCode and serialization changes * made inline * Space Corrected Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
…upport (#16379) * Add ReadOnlySpan string-like ToLower/ToUpper API with globalization support * Address PR feedback. Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
…ions (#27146) * Fix bug in RegexWriter ref struct change * Remove duplicate ValueListBuilder implementation * Enable ILLinkClearInitLocals * Rename concrete ValueListBuilder impl to Pop Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com> Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
I was setting up a new machine today so I played with a "new user" experience. Before this change, `dotnet publish` without VS installed would result in a message like ``` C:\Users\michals\.nuget\packages\microsoft.dotnet.ilcompiler\1.0.0-alpha-26216-01\build\Microsoft.NETCore.Native.Windows.props(83,5): error MSB3073: The command ""C:\Users\michals\.nuget\packages\microsoft.dotnet.ilcompiler\1.0.0-alpha-26216-01\build\findvcvarsall.bat" amd64" exited with code 1. [D:\Temp\hello\hello.csproj] ``` After this change, we get ``` C:\Users\michals\.nuget\packages\microsoft.dotnet.ilcompiler\1.0.0-alpha-26216-01\build\Microsoft.NETCore.Native.Windows.props(101,5): error : Platform linker not found. To fix this problem, download and install Visual Studio 2017 from http://visualstudio.com. Make sure to install the Desktop Development for C++ workload. [D:\Temp\hello\hello.csproj] ```
A-And
pushed a commit
to A-And/corert
that referenced
this pull request
Feb 20, 2018
Merge master to nmirror
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.