CoreRT is using System.Runtime.Extensions.dll compiled for CoreCLR, not CoreRT. System.Runtime.Extensions depends on Marshal.ThrowExceptionForHR in CoreLib.

Also made Marshal.ThrowExceptionForHR to throw COMException instead PlatformNotSupportedException for CoreRT without COM interop support. It should eventually probably map the HResult to exception even without the COM support once the interop is factored better.

Fixes #5373

Merge nmirror to master

Port dotnet/coreclr#16431 to CoreRT

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

* accommondate -> accommodate

* aligment -> alignment

* apppropriate -> appropriate

* artifically -> artificially

* artifical -> artificial

* gaurantee -> guarantee

* Asssembly -> Assembly

* asychnronously -> asynchronously

Seems like this got unblocked and I was able to get a clean build and test run with this.

Fixes #2856.

We stopped supporting VS 2015 a while ago, but running CoreCLR tests didn't actually work without it because we forgot to update a place.

* begining -> beginning

* boundry -> boundary

* cachced -> cached

* calback -> callback

* callled -> called

* chosing -> choosing

* clearded -> cleared

* commiting -> committing

* Compactiony -> Compaction

* contruct -> construct

* cooresponding -> corresponding

* coresponding -> corresponding

* cuase -> cause

Picks up the latest version of Pri0 tests (as of yesterday).

There was a massive cleanup of Pri0 tests on the CoreCLR side so we now run only about 2000 tests. Hopefully, they're more representative now. Most of what we picked as "Top200" was no longer part of the Pri0 suite, so I made a new one.

We might want to consider switching to Pri1 for the rolling builds.

Indexer that let's you see and edit the content of the pending string is more efficient and flexible.

Fixes #26643

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

* Add TryGetOwnedMemory

* Feedback

* spelling

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

* Moved extensions.cs to shared folder

* added to shared to projItems

* Added new constructor

* Parameter Named Changed

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

* Dial back aggressive checks in Path

Aggressive checks are preventing crossplat and extended Windows solutions. This change:

- Doesn't throw on empty paths fro GetDirectoryName, GetPathRoot
- Doesn't consider colon when looking at path segments on Windows
- Moves non-shared code out of PathInternal
- Fix span GetDirectoryName to handle multiple separators

* Comment updates

* Check for valid drive letter with PathRoot
Remove other usages of PathSkip (related to #16311)

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

…cannot create the stub (#5406)

- Remove WINRT ifdef from GetDelegateForFunctionPointer to consistently throw MissingInteropDataException instead of returning null. Fixes #5162.
- Move McgPInvokeData set of structure to System.Private.Interop since it is MCG specific
- Rename a few things for consistency (e.g. PInvokeMarshal.GetPInvokeDelegateForStub did not make sense since it operates on user supplied function pointers, not stubs)

MarshalImpl is an extra layer without clear purpose. Also made MarshalAdapter to be included in CoreCLR/Mono builds only.

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

Trying to debug ILCompiler in Visual Studio was failing with missing assemblies. The problem was caused by recently added libLLVMdep.depproj reference that made NuGet delete certain files from the output tools directory. The fix is to move the .depproj reference to a different part of the build next to other similar .depproj reference where it won't be confusing NuGet.

…s (#27338)

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

)

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

…16505)

* Add CoreLib helpers for MemoryExtensions.AsSpan/AsMemory(T[], int)

(Part of https://github.com/dotnet/corefx/issues/26894)

We intentionally don't have (T[], int] constructor overloads
for Span and Memory. So as not to incur unnecessary argument checks,
we implement this directly in CoreLib and will invoke it from
CoreFx for the fast-Span version.

* Expose an internal array-int constructor instead.

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

* Removing the colon block that tosses out paths that are not device path.

Fixes: #26359

* Striping 2nd and 3rd args of PathHelper.Normalize

* Build on Maryam's changes

- Remove all path validity checks outside of
    - Null
    - Embedded null
    - Empty or all spaces (effectively empty)
- Remove PathStartSkip helper
- Use span overloads for StringBuffer usage
- Clean up some comments

* Address feedback

* Tweak to match other AsSpan methods

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

…th globalization support (#16467)

* Add ReadOnlySpan string-like Equals/CompareTo/IndexOf/Contains API with globalization support

* Address PR feedback.

* Fix unix implementation

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

* decommand -> demand

* definfed -> defined

* dependen -> dependent

* dequed -> deque

* derefencing -> dereferencing

* detemine -> determine

* deterine -> determine

* differenct -> different

* Rename string-slicing extension methods

As part of

https://github.com/dotnet/corefx/issues/26894

the api folks have approved renaming AsROSpan and AsROMemory
on string instances to AsSpan and AsMemory (as the "readonly"
is obvious given the read-only nature of the input.)

This puts the renaming in effect. Basically a big search-replace
commit.

* Fix OpenSSL build break

* I see this is going to be a treadmill

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

* Remove StringBuffer and use ValueStringBuilder

* Address initial feedback

* Address further feedback

* Address some more feedback

* Put back the temporary builder for output.

* Make the temp var ref

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

`CorInfoTokenKind.CORINFO_TOKENKIND_Constrained` means RyuJIT is asking for a type handle with the purpose of boxing it.

This fixes:

```csharp
struct Foo { }
void Main() { Foo f = default; f.GetHashCode() }
```

We were trying to execute bogus memory because unconstructed types don't have vtables.

#5351)

* Convert ILVerify, ILVerification and ILVerification.Tests to old build
system

* Respond to PR Feedback

* Change target frameworks add runtime config

* Change accessor and debugging files

* Mirror ILCompiler debugging in ILVerify

* Case change

* Add runtime options property to ILVerify runtime json

* crtitical -> critical

* elligible -> eligible

* emory -> memory

* enquing -> enqueuing

* enumarate -> enumerate

* eqivalent -> equivalent

* execeptions -> exceptions

* exectuing -> executing

* forceably -> forcibly

* fragmentatioin -> fragmentation

* fragramented -> fragmented

* geneated -> generated

* generaion -> generation

* handes -> handles

* higest -> highest

* Fix newline issue/duplicate message on Contract failures

* make it work on Unix as well

* cleanup

* Add a newline between error/user messages and stacktrace

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

* Return empty array if length is zero

* Return true

* Add support for portable system

* Use portable span helper instead of Array.Empty

* Move to end

* Remove else

* Return empty array if length is 0 in MemoryMarshal

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

Path tests weren't running so a few issues sneaked in.

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

…6551)

Fix #6237

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

* interruptbile -> interruptible

* legnth -> length

* neccessary -> necessary

* neeed -> need

* occurance -> occurrence

* occuring -> occurring

* otheriwse -> otherwise

* Ouput -> Output

* Ouput -> Output

* peformed -> performed

Having a call to `IsByRefLike` in the type unifier meant that an app that uses a simple `typeof()` would require the full reflection stack to be present in the image (all of the custom attribute resolution, method resolution, etc.).

This is a step towards having a more pay for play framework (a hello world EXE really should not have the full reflection stack compiled in it).

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

Port CoreCLR #16588. This is under #if 0 in CoreRT right now, but it does not hurt to keep it in sync.

The implementation relies on a new virtual method on `System.ValueType` that provides information about fields on a type. An override of this method is injected by the compiler when needed.

This implementation is different from what Project N does (where we inject actual overrides of both methods). The CoreRT implementation is a bit more space-saving because there is only one method that does fewer things.

This ends up being a 0.9% regression in size of a hello world app, but we do get some correctness with it and a potential to get the reflection stack completely out of the base hello world image (that one will be a huge win). We can get some of the regression back by:

* Getting RyuJIT to generate more efficient code for the offset calculation (dotnet/coreclr#16527)
* Making fewer things reflectable. We're currently generating the data for e.g. OSVERSIONINFO because it's used as a parameter in a method that is reflectable, and therefore the parameter gets boxed, and therefore it needs this data. It also drags in a fixed buffer internal type because it's a valuetype field on OSVERSIONINFO. This alone costs us 100+ bytes.

Merge nmirror to master

…521)

* Add MemoryExtensions to CoreLib along with necessary SpanHelpers

* Make the newly added AsSpan/AsMemory into array extension methods.

* Remove StringSpanHelpers.Trim

* Leftover AsReadOnlySpan -> AsSpan for *Unix.cs files

* Address PR feedback.

* Remove duplicate methods in the Span class.

* Temporarily disable AsBytes SpanBench test.

* Add back AsBytes

* Re-enable AsBytes SpanBench test

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

* some refactor to remove dumplicated code in tests and make them fit 1 screen

* write the failing test for no activity id

* use 17, the "free slot" of TypeCode enum to represent Guid in event pipe metadata

* remove the test which would not pass until new trace event is released and Event Pipe enabled for Windows

* added comment to TypeCode about using the value 17

* post code review fixes (thanks @justinvp)

* post code review fixes (thanks @brianrob)

* refactor the rest of event pipe tests to use NetPerfFile helper

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

* GetFullPath and GetRootLength Corrected

* Removed getpathroot

* using span

* "\\" changed to @"\"

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

…5377)

* Implement intrinsic call to InitializeArray.

RuntimeHelpers.InitializeArray is implemented as a call to LLVM
intrinsic llvm.memcpy.p0i8.p0i8.i32, which copies from generated global
constant to provided target array.

Currently the base size of the array object is hardcoded to 8, since no
EEType is provided in the intrinsic call.

Fix #5345.

Add testing code for InitializeArray in HelloWasm.

Roslyn generates RuntimeHelpers.InitializeArray for arrays of integral
types with initializer of length greater or equal than 3. Here we use
this feature to generate a call to RuntimeHelpers.InitializeArray for
test.

Catagorize array argument types in InitializeArray

Differently handle vectors, multidimensional arrays and object typed
arrays in InitializeArray intrinsic.

This is a recursive algorithm and there's a pathological test in the CoreCLR test assets that has been timing out ever since the code was introduced.

Made the cache a bit more general purpose, since I'm expecting this to be reused for more things later.

…#27494)

Corrects its Implementation too

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

* Add Path.Join() methods.

See #25536.

* Address feedback and fix a couple issues now that I've got tests running correctly.

* Update per final API approval

* Fix Unix, remove redundant helper.

* Merge and tweak join methods in GetFullPath(string, string)

* Tweak again

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

Add CA2111 SuppressMessage for these MSDN documented public Pointers

* Use correct name to fetch embedded resource

* Fix the test project

* Use GetTypeInfo().Assembly

)

Fixed minor space changes and one syntax error that causes conflict between checked in Vector.cs file and the freshly auto-generated Vector.cs file.

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

Fixes dotnet/corefx#27554

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

* Remove span helpers, use mirrored PathInternal helper

Remove other unnecessary helpers (notably with Path.Join available)

* Fix Unix

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

…ensibility

Implement ValueTask extensibility

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

Avoid unnecessary checked and signed arithmetic. Handle special cases such as cast between same size types and from byte sized types, the JIT is unable to optimize these cases currently.

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

…#16689)

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

…Array (#16692)

* Remove Span.NonGenerics and update leftover AsRoS -> AsSpan changes

* Move MemoryExtensions.TryGetString to MemoryMarshal and remove TryGetArray

* Move TryGetString to common MemoryMarshal.cs

* Remove the `this` keyword, not an extension method

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

These do unsafe casts on an object, and we don't want a debugger's automatic evaluation accidentally invoking them.  That means either making them methods or adding [DebuggerBrowsable(DebuggerBrowsableState.Never)], and the former seems cleaner.

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

The change in the P/invoke signature that came from CoreCLR triggers a bug in MCG on the TFS side.

The returned data from ICU has 6th month name as 'Adar I' and 7th month name as 'Adar'
We need to adjust that in the list used with non-leap year to have 6th month as 'Adar' and 7th month as 'Adar II'
note that when formatting non-leap year dates, 7th month shouldn't get used at all.

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

* Vectorize String.IndexOf(char) using the same algorithm as SpanHelpers
IndexOf(byte).

* Respond to feedback.

* Vectorize String.LastIndexOf

Clean up IndexOf vectorization.

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>