Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RISC-V] Build coredistools #387

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Conversation

tomeksowi
Copy link
Contributor

…ainer because there is no CBL Mariner container for RISC-V. Besides, it's more convenient to work in one docker only.
@tomeksowi tomeksowi marked this pull request as ready for review January 19, 2024 07:20
@tomeksowi
Copy link
Contributor Author

Close and reopen PR to rerun the CI.

@tomeksowi tomeksowi closed this Jan 23, 2024
@tomeksowi tomeksowi reopened this Jan 23, 2024
@tomeksowi
Copy link
Contributor Author

IMO the timeout on dotnet-jitutils-coredistools CI wasn't caused by this change, other open PRs seem to have similar issues.

@BruceForstall could you review this please?

Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

Yes, the timeout in CI is a known problem.

@BruceForstall BruceForstall merged commit 9db9e22 into dotnet:main Jan 23, 2024
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants