Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RISC-V] Enable R2RDump #97156

Merged
merged 2 commits into from
Jan 27, 2024
Merged

[RISC-V] Enable R2RDump #97156

merged 2 commits into from
Jan 27, 2024

Conversation

tomeksowi
Copy link
Contributor

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-R2RDump-coreclr Ready-to-run image dump tool label Jan 18, 2024
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jan 18, 2024
sirntar
sirntar approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@sirntar sirntar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@build-analysis build-analysis bot mentioned this pull request Jan 18, 2024
Closed
wscho77
wscho77 approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@wscho77 wscho77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clamp03 clamp03 added the arch-riscv Related to the RISC-V architecture label Jan 19, 2024
@tomeksowi
Copy link
Contributor Author

@trylek could you review this please? (the CI failures look unrelated to this PR)

@clamp03 clamp03 requested review from trylek and jkotas January 27, 2024 02:38
jkotas
jkotas approved these changes Jan 27, 2024
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas jkotas merged commit 08d9819 into dotnet:main Jan 27, 2024
105 of 110 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wscho77 wscho77 wscho77 approved these changes

@clamp03 clamp03 clamp03 approved these changes

@jkotas jkotas jkotas approved these changes

@gbalykov gbalykov gbalykov approved these changes

@ashaurtaev ashaurtaev ashaurtaev approved these changes

@sirntar sirntar sirntar approved these changes

@Bajtazar Bajtazar Bajtazar approved these changes

@trylek trylek Awaiting requested review from trylek

Assignees

@tomeksowi tomeksowi

Labels
arch-riscv Related to the RISC-V architecture area-R2RDump-coreclr Ready-to-run image dump tool community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tomeksowi @wscho77 @clamp03 @jkotas @gbalykov @ashaurtaev @sirntar @Bajtazar