Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loc update #4805

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Loc update #4805

merged 1 commit into from
Feb 16, 2021

Conversation

cristianosuzuki77
Copy link
Contributor

Loc update

@cristianosuzuki77 cristianosuzuki77 requested a review from a team as a code owner February 9, 2021 01:29
@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #4805 (4627a34) into release/5.0.2xx (59b4e0b) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           release/5.0.2xx    #4805      +/-   ##
===================================================
- Coverage            95.86%   95.82%   -0.05%     
===================================================
  Files                 1209     1164      -45     
  Lines               289468   265013   -24455     
  Branches             22738    16160    -6578     
===================================================
- Hits                277503   253947   -23556     
+ Misses                9869     9049     -820     
+ Partials              2096     2017      -79     

@Youssef1313
Copy link
Member

Tagging @buyaa-n for test failures.

@wli3
Copy link

wli3 commented Feb 9, 2021

@sharwell could you look into the error and merge this?

@wli3
Copy link

wli3 commented Feb 9, 2021

@sharwell and this ships in SDK right? Could you make sure there is an insertion to SDK later with the loc change?

@buyaa-n
Copy link
Contributor

buyaa-n commented Feb 9, 2021

Tagging @buyaa-n for test failures.

Thanks, @Youssef1313, this was fixed before, but seems was not merged into release/5.0.2xx i will open PR into release/5.0.2xx

@buyaa-n
Copy link
Contributor

buyaa-n commented Feb 9, 2021

PR #4821

@genlu genlu closed this Feb 9, 2021
@genlu genlu reopened this Feb 9, 2021
@mavasani
Copy link
Contributor

@buyaa-n This PR should be merged or closed?

@wli3
Copy link

wli3 commented Feb 16, 2021

Please merge this once the branch is correct

@buyaa-n
Copy link
Contributor

buyaa-n commented Feb 16, 2021

@buyaa-n This PR should be merged or closed?

@mavasani the test failures fixed with different PR, this is ready for review and merge

Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any non-localization related changes, i assume loc changes already reviewed so LGTM, merging

@buyaa-n buyaa-n merged commit 31d239c into dotnet:release/5.0.2xx Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants