-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loc update #4805
Loc update #4805
Conversation
Codecov Report
@@ Coverage Diff @@
## release/5.0.2xx #4805 +/- ##
===================================================
- Coverage 95.86% 95.82% -0.05%
===================================================
Files 1209 1164 -45
Lines 289468 265013 -24455
Branches 22738 16160 -6578
===================================================
- Hits 277503 253947 -23556
+ Misses 9869 9049 -820
+ Partials 2096 2017 -79 |
Tagging @buyaa-n for test failures. |
@sharwell could you look into the error and merge this? |
@sharwell and this ships in SDK right? Could you make sure there is an insertion to SDK later with the loc change? |
Thanks, @Youssef1313, this was fixed before, but seems was not merged into |
PR #4821 |
@buyaa-n This PR should be merged or closed? |
Please merge this once the branch is correct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any non-localization related changes, i assume loc changes already reviewed so LGTM, merging
Loc update