Support for detecting preview-ness in dependencies #5395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgovind
requested review from
jeffhandley,
sharwell,
stephentoub,
jmarolf and
buyaa-n
pgovind
commented
Aug 20, 2021
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/DetectPreviewFeatureAnalyzer.cs
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## release/6.0.1xx #5395 +/- ##
=================================================
Coverage 95.56% 95.56%
=================================================
Files 1256 1257 +1
Lines 288892 289065 +173
Branches 17363 17368 +5
=================================================
+ Hits 276069 276249 +180
+ Misses 10494 10489 -5
+ Partials 2329 2327 -2 |
jeffhandley
approved these changes
Aug 21, 2021
buyaa-n
reviewed
Aug 23, 2021
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/DetectPreviewFeatureAnalyzer.cs
Outdated
Show resolved
Hide resolved
buyaa-n
reviewed
Aug 23, 2021
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/DetectPreviewFeatureAnalyzer.cs
Outdated
Show resolved
Hide resolved
pgovind
commented
Aug 23, 2021
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/DetectPreviewFeatureAnalyzer.cs
Show resolved
Hide resolved
This was referenced Aug 30, 2021
Merged
This was referenced Sep 10, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The containing symbol information for dependencies didn't work the way I expected. If a symbol is not contained within a type,
symbol.ContainingSymbolreturns null. However thesymbol.ContainingAssemblyandsymbol.ContainingModuleare populated correctly, so we can use those instead.Contributes to https://github.com/dotnet/designs/blob/main/accepted/2021/preview-features/preview-features.md