Merge master back to stabilization #11616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid loading the Elfie dll until the user actualy enables the search feature.
…e names we store for a type.
Extending the supported functionality of the VisualStudio IntegrationTest Utilities and adding the start of 'CSharpAutomaticBraceCompletion'
Add missed code hooking up the option for /**/ comments
…FromInterfacesAsync and FindDerivedClassesAsync
1. Reference a bunch of stuff from Nuget packages instead of VS. 2. Move to Update 2 versions of packages. 3. Now that we are using the packages, we're referencing Microsoft.VisualStudio.Shell.14.dll instead of .15 again. This means that types that moved to Shell.Immutable.15 are not type forwarders. Luckily we didn't need anything from Shell.Immutable.15 in the project where it was a problem.
More cleanup to do between RoslynCompletionSet and FilteredRoslynCompletionSet.
Add better error messages for public signing
Allow foreach with string even if string does not implement foreach pattern.
Disallow sealed overrides in structs
Restore backward compatibility in the way conversion from a reference type to an intrinsic value type is evaluated.
The intent of ServerRespectsAppConfig was to verify the server actually read the default timeout value from the application configuration file. The test validated this in a very indirect way: - Changing the value in app.config - Starting the server - Verifying it stopped in the given time frame This can fail for a number of reasons: computer load during the test, another process communicating with the server, etc ... Changed the test to just directly test the value being read from application settings. Justification for ask mode: this test was flaky enough to break signed builds.
made 2 states (designer or not) to 3 states (designer, not, unknown)
…al to avoid NullReferenceException. The change addresses the situation when SemanticModel is created to speculate on a With block and the function is trying to locate a binder for the With expression within the block. Fixes https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems?id=187910&_a=edit.
Fix a flaky compiler suite
…lues (#11532) Do not report warnings for malformed InformationalVersionAttribute values
Utilize new archival options Only archive when failing, rather than always.
…#11541) * Initialize the error list toggle state when error list is initialized Currently, we initialize the error list toggle state only when workspace changes (solution add/remove/reload or project add/remove/reload) OR when FSD options change. However, if you start VS and bring up error list without opening any solution or changing FSD options, we might show stale error list state if your settings file or settings store changed from last VS session. Fix is to initialize the error list toggle state as soon as error list is initialized. Fixes #11539 * Don't change the error list toggle state on workspace changes.
Iterator Property setter should not be treated as an iterator
Adjust implementation of MemberSemanticModel.GetEnclosingBinderInternal to avoid NullReferenceException.
Port #11398 over to SymbolKeys. …
Assert that completion has a TypeInferenceService
…1) attribute (#11536) * Bug 217740: Repro and test harness for C# * Testing and fixing loading scenario in C# and VB * Verifying VB case using attribute on field * Adding more tests * Adding VB tests * Adding tests * More tests on fields with double-attributes * New test constraint * Fixing VB side to new test constraints * Fixing C# side to new test constraints * Fixing remaining tests * Adding comments * Fixing VB field scenario too
|
Hi @panopticoncentral, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
|
@panopticoncentral, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.