-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge master to features/module-initializers #43714
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧹 Simplify import of Microsoft.VsSDK.targets
…config Add telemetry for Tools->Options generate editorconfig
Remove public API on DocumentOptionSet
Enabled partial ngen for LanguageServices
Merge release/dev16.6 to master
🐇 Implement AsyncQueue<T>.TryDequeueAsync
Move the 'application/validation/resolution' portion of rename OOP.
Add overload for rpc that can work on streams, not just object writers.
This makes the following changes to our ability to build the current project from VSCode (essentially implementing the rough equivalent of build current project in VS). - Ability to choose `msbuild` in addition to `dotnet msbuild`. The full framework `msbuild` is still necessary for building parts of the IDE code base. - Support for VB projects - Fixes the execution of the task on Windows. The hard dependency on `/.dotnet` existing doesn't hold on Windows. Falling back to normal powershell in that environment
🐇 Avoid computing unnecessary semantic models
Support a single OOP call to perform all of rename, on top of the individual pieces of rename that are already OOPed
Co-Authored-By: Rikki Gibson <rikkigibson@gmail.com>
Improve VS Code build current project support
…deDiagnosticAnalyzer.cs
Don't offer to use System.HashCode when the existing GetHashCode is already simple enough.
Don't remove null-casts in switch expressions
cston
approved these changes
Apr 27, 2020
ghost
approved these changes
Apr 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-approval
…Rename Update inline rename code following completion of TypeScript external access work
Derp, master is a moving target, so PR checks will often need to restart. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No implementation PRs have been merged to the feature branch yet. This is needed to fix integration tests for #43281.