Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master to features/module-initializers #43714

Merged
merged 678 commits into from
Apr 27, 2020

Conversation

RikkiGibson
Copy link
Contributor

No implementation PRs have been merged to the feature branch yet. This is needed to fix integration tests for #43281.

dpoeschl and others added 30 commits April 17, 2020 13:59
🧹 Simplify import of Microsoft.VsSDK.targets
…config

Add telemetry for Tools->Options generate editorconfig
Remove public API on DocumentOptionSet
Enabled partial ngen for LanguageServices
sharwell and others added 18 commits April 24, 2020 21:04
🐇 Implement AsyncQueue<T>.TryDequeueAsync
Move the 'application/validation/resolution' portion of rename OOP.
Add overload for rpc that can work on streams, not just object writers.
This makes the following changes to our ability to build the current
project from VSCode (essentially implementing the rough equivalent of
build current project in VS).

- Ability to choose `msbuild` in addition to `dotnet msbuild`. The full
framework `msbuild` is still necessary for building parts of the IDE
code base.
- Support for VB projects
- Fixes the execution of the task on Windows. The hard dependency on
`/.dotnet` existing doesn't hold on Windows. Falling back to normal
powershell in that environment
🐇 Avoid computing unnecessary semantic models
Support a single OOP call to perform all of rename, on top of the individual pieces of rename that are already OOPed
Co-Authored-By: Rikki Gibson <rikkigibson@gmail.com>
Improve VS Code build current project support
Don't offer to use System.HashCode when the existing GetHashCode is already simple enough.
Don't remove null-casts in switch expressions
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

…Rename

Update inline rename code following completion of TypeScript external access work
@RikkiGibson
Copy link
Contributor Author

Derp, master is a moving target, so PR checks will often need to restart.

@JoeRobich JoeRobich merged commit 176ad60 into features/module-initializers Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.