Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge master to features/module-initializers #45634

Merged
14 commits merged into from
Jul 3, 2020
Merged

Merge master to features/module-initializers #45634

14 commits merged into from
Jul 3, 2020

Commits on Jul 1, 2020

  1. Update VirtualMemoryNotificationListener.cs 

    Fixes #44139.
    @allisonchou
    allisonchou authored Jul 1, 2020
    Configuration menu
    Copy the full SHA
    2b05dfd View commit details
    Browse the repository at this point in the history

  2. https instead of http

    @allisonchou
    allisonchou authored Jul 1, 2020
    Configuration menu
    Copy the full SHA
    54a38b3 View commit details
    Browse the repository at this point in the history

  3. Fix issue preventing going to def on a complicated metadata symbol in… 

    …volving nullability and generics
    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    87a7055 View commit details
    Browse the repository at this point in the history

  4. Add tests

    @CyrusNajmabadi
    CyrusNajmabadi committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    f9585db View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2020

  1. Fixing VS Crash on invalid "MemberNotNull" (#45563) 

    * Update AttributeTests.cs

* Update NullableReferenceTypesTests.cs

* Update NullableReferenceTypesTests.cs

* Fixed NullPointerException

* Removed duplicate test

* PR changes

* Added Robustness and Nullable Checks

* PR Changes

* Moved test to avoid merge conflict
    Kevin Sun authored Jul 2, 2020
    Configuration menu
    Copy the full SHA
    be56bf4 View commit details
    Browse the repository at this point in the history

  2. Handle invalid dotnet_diagnostic entry without ID part in configurati… 

    …on code fix

Fixes #45446
    @mavasani
    mavasani committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    64d702c View commit details
    Browse the repository at this point in the history

  3. Fix AD0001 for IDE0076 

    Fixes #45465
Ensure we normalize the target scope passed to target symbol resolver. It doesn't handle the recently added 'namespaceanddescendants' scope in legacy target string format and expects it to be normalized to 'namespace' scope.
    @mavasani
    mavasani committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    a08c596 View commit details
    Browse the repository at this point in the history

  4. Remove obsolete UnitTesting external access APIs (#45553)

    @tmat
    tmat authored Jul 2, 2020
    Configuration menu
    Copy the full SHA
    ec72c14 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #45594 from CyrusNajmabadi/gotoDefNullable 

    Fix issue preventing going to def on a complicated metadata symbol involving nullability and generics
    @CyrusNajmabadi
    CyrusNajmabadi authored Jul 2, 2020
    Configuration menu
    Copy the full SHA
    ef2ad43 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #45615 from mavasani/FixArgException 

    Handle invalid dotnet_diagnostic entry without ID part in configurati…
    msftbot[bot] authored Jul 2, 2020
    Configuration menu
    Copy the full SHA
    295eaa6 View commit details
    Browse the repository at this point in the history

  7. Merge pull request #45613 from mavasani/FixAD0001ForIDE0076 

    Fix AD0001 for IDE0076
    msftbot[bot] authored Jul 2, 2020
    Configuration menu
    Copy the full SHA
    f9bd4ff View commit details
    Browse the repository at this point in the history

  8. Align addition of a synthesized override of Base.Equals(Base? other) … 

    …in records with the latest design. (#45601)

Related to #45296.

From specification:
If the record type is derived from a base record type Base, the record type includes a synthesized override of the strongly-typed Equals(Base other). The synthesized override is sealed. It is an error if the override is declared explicitly. The synthesized override returns Equals((object?)other).

This change also adjusts code-gen to properly compare EqualityContracts.
    @AlekseyTs
    AlekseyTs authored Jul 2, 2020
    Configuration menu
    Copy the full SHA
    79f298b View commit details
    Browse the repository at this point in the history

  9. Merge pull request #45592 from dotnet/dev/allichou/link_revert 

    Revert link to previous URL
    @allisonchou
    allisonchou authored Jul 2, 2020
    Configuration menu
    Copy the full SHA
    69c96be View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2020

  1. Merge branch 'features/module-initializers' into merges/master-to-fea… 

    …tures/module-initializers
    @RikkiGibson
    RikkiGibson authored Jul 3, 2020
    Configuration menu
    Copy the full SHA
    47e448e View commit details
    Browse the repository at this point in the history