Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge features/compiler into main branch #53125

Merged
merged 85 commits into from
May 4, 2021
Merged

Conversation

jcouv
Copy link
Member

@jcouv jcouv commented May 4, 2021

This includes first phase of lambda improvements, global usings and record structs.

Minor conflicts in IDE during merge. See the last commit: 1c84581

Youssef1313 and others added 30 commits February 18, 2021 12:13
Refresh record-structs branch with latest bits from master
Merge `master` into `GlobalUsingDirective`
This is a refactoring, no behavior change intended.
…orts and looking up in imports. (dotnet#51676)

- Introducing specialized binders that are focused on a single specific lookup tasks: lookup in aliases, or lookup in imported namespaces and types.
- All lookup helpers from Imports type are moved to binder types. This removing dependency on an Imports instance for lookup operations.
- Binding of imports is moved from Imports type to symbols that “own” the imports (i.e. namespaces and compilation).
- Bound information about imports (including symbols for aliases) is now persisted in the symbol table. It can be bound once and retrieved without having to recreate a binder chain every time the information is needed. The information used to be transient, persisted only in a binder chain and recomputed individually by each chain.
- Usage of Imports type is now mostly limited to supporting PDBs and manipulations specific to interactive submissions.
- Functionality to handle special lookup rules in submission classes is moved from InContainerBinder to a new specialized InSubmissionClassBinder.
…or-record

Recommend struct and class keywords after record
Merge 'main' into features/GlobalUsingDirective
Merge 'main' into 'features/GlobalUsingDirective'
Merge latest bits from main into record-structs
Merge `main` into `features/GlobalUsingDirective`
@jcouv jcouv added this to the C# 10 milestone May 4, 2021
@jcouv jcouv self-assigned this May 4, 2021
@jcouv jcouv changed the title Merge compiler/features into main branch Merge features/compiler into main branch May 4, 2021
@jcouv jcouv marked this pull request as ready for review May 4, 2021 02:42
@jcouv jcouv requested review from a team as code owners May 4, 2021 02:42
@jcouv jcouv merged commit 12ca809 into dotnet:main May 4, 2021
@ghost ghost modified the milestones: C# 10, Next May 4, 2021
@jcouv jcouv deleted the merge-features branch May 4, 2021 14:46
@jcouv
Copy link
Member Author

jcouv commented May 4, 2021

FYI @Youssef1313 @CyrusNajmabadi, the situation changed from last week (where we were trying to keep bits from main separate from the new compiler features) and were able to merge the C# 10 work so far into the main branch. We won't be using features/compiler anymore in the foreseeable future.

@RikkiGibson
Copy link
Contributor

@dotnet/roslyn-infrastructure I expected to see a non-Next milestone in this PR. Did we miss the snap step where we assign the PRs to milestones?

@RikkiGibson RikkiGibson modified the milestones: Next, 17.0.P2 Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants