Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge main to main-vs-deps #57605

Merged
merged 85 commits into from
Nov 8, 2021
Merged

Merge main to main-vs-deps #57605

merged 85 commits into from
Nov 8, 2021

Commits on Jul 4, 2021

  1. Fix spacing when generating editorconfig options from UI

    @Youssef1313
    Youssef1313 committed Jul 4, 2021
    Configuration menu
    Copy the full SHA
    fad93f9 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2021

  1. Minor refactoring in SettingsUpdateHelper

    @Youssef1313
    Youssef1313 authored Jul 26, 2021
    Configuration menu
    Copy the full SHA
    b077566 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2021

  1. WIP: First successful fix of CS1591

    @MaStr11
    MaStr11 committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    fa32397 View commit details
    Browse the repository at this point in the history

  2. WIP:Change to new test harness

    @MaStr11
    MaStr11 committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    1a06526 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2021

  1. WIP: Use new test suite. Make test pass.

    @MaStr11
    MaStr11 committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    fcc996a View commit details
    Browse the repository at this point in the history

  2. Support CodeActionValidationMode.Full, take newLine from options and … 

    …calculate indentation.
    @MaStr11
    MaStr11 committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    31c20d8 View commit details
    Browse the repository at this point in the history

  3. Fix test method name.

    @MaStr11
    MaStr11 committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    4bfc52f View commit details
    Browse the repository at this point in the history

  4. Only offer on overriden member or implicit or explicit interface impl… 

    …ementation.
    @MaStr11
    MaStr11 committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    26db397 View commit details
    Browse the repository at this point in the history

  5. Fix explicit interface implementation in C#.

    @MaStr11
    MaStr11 committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    5fa5fce View commit details
    Browse the repository at this point in the history

  6. Add tests for properties and existing trivia

    @MaStr11
    MaStr11 committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    46ec060 View commit details
    Browse the repository at this point in the history

  7. Add trivia test and test with attribute on method.

    @MaStr11
    MaStr11 committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    b54ecff View commit details
    Browse the repository at this point in the history

  8. Add FixxAll test.

    @MaStr11
    MaStr11 committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    5650259 View commit details
    Browse the repository at this point in the history

  9. Add "Add_Inheritdoc_documentation_comment" to Feature resources.

    @MaStr11
    MaStr11 committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    a4673e1 View commit details
    Browse the repository at this point in the history

  10. Apply Add_inheritdoc_documentation_comment to CodeAction.Title.

    @MaStr11
    MaStr11 committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    ba8f2f0 View commit details
    Browse the repository at this point in the history

  11. Remove _1 from test method

    @MaStr11
    MaStr11 committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    7f2d659 View commit details
    Browse the repository at this point in the history

  12. Add space between /// and <inheritdoc/>

    @MaStr11
    MaStr11 committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    005cc31 View commit details
    Browse the repository at this point in the history

  13. Fix code comment to match the newly created code comment.

    @MaStr11
    MaStr11 committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    cac1947 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2021

  1. Rename AddInheritdocCodeFixProvider.cs

    @MaStr11
    MaStr11 committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    e968aec View commit details
    Browse the repository at this point in the history

  2. Rename AddInheritdocTests.cs

    @MaStr11
    MaStr11 committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    cb71346 View commit details
    Browse the repository at this point in the history

  3. Rename InheritDoc to Inheritdoc in classes, variables, test names, tr… 

    …aits and consts
    @MaStr11
    MaStr11 committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    6991e1b View commit details
    Browse the repository at this point in the history

  4. Simplify TestMissingAsync

    @MaStr11
    MaStr11 committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    d8d5f2b View commit details
    Browse the repository at this point in the history

  5. Move Trait to test class

    @MaStr11
    MaStr11 committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    2dd7e98 View commit details
    Browse the repository at this point in the history

  6. Fix spelling

    @MaStr11
    MaStr11 committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    930e3af View commit details
    Browse the repository at this point in the history

  7. Replace calls to TestFixAllAsync with isomorphic TestAsync

    @MaStr11
    MaStr11 committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    0983c5e View commit details
    Browse the repository at this point in the history

  8. Make RegisterCodeFixesAsync to iterate over the diagnostics instead o… 

    …f picking one.
    @MaStr11
    MaStr11 committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    85b1b67 View commit details
    Browse the repository at this point in the history

  9. Change Codefix title 

    Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>
    @MaStr11 @sharwell
    MaStr11 and sharwell authored Oct 9, 2021
    Configuration menu
    Copy the full SHA
    fb756f5 View commit details
    Browse the repository at this point in the history

  10. Rename codefix title

    @MaStr11
    MaStr11 committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    b9466b4 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2021

  1. Refactor: Replace Where() with imperative equivalent in hot path.

    @MaStr11
    MaStr11 committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    1ef7373 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2021

  1. Use RequiredSemanticModel and spelling fix 

    Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>
    @MaStr11 @sharwell
    MaStr11 and sharwell authored Oct 13, 2021
    Configuration menu
    Copy the full SHA
    b4ab946 View commit details
    Browse the repository at this point in the history

  2. Small changes from code review

    @MaStr11
    MaStr11 committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    2f10260 View commit details
    Browse the repository at this point in the history

  3. Add support for event fields implementing an interface.

    @MaStr11
    MaStr11 committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    74989ca View commit details
    Browse the repository at this point in the history

  4. Remove #nullable disable in test file.

    @MaStr11
    MaStr11 committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    2d21217 View commit details
    Browse the repository at this point in the history

  5. Use SyntaxFactory.TriviaList

    @MaStr11
    MaStr11 committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    b61c7ac View commit details
    Browse the repository at this point in the history

  6. Use GetLeadingWhitespaceOfLineAtPosition to get indentation,

    @MaStr11
    MaStr11 committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    d2d2572 View commit details
    Browse the repository at this point in the history

  7. Use SyntaxFactory.TriviaList

    @MaStr11
    MaStr11 committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    726cb7e View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2021

  1. Add the benchmark to test the glyph

    @Cosifne
    Cosifne committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    d83f851 View commit details
    Browse the repository at this point in the history

  2. Add benchmark to test InheritanceMarginItem generation

    @Cosifne
    Cosifne committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    9547a6c View commit details
    Browse the repository at this point in the history

  3. Clean some unnecessary IVTs

    @Cosifne
    Cosifne committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    0e11d0a View commit details
    Browse the repository at this point in the history

  4. Switch to a smaller size solution

    @Cosifne
    Cosifne committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    e22c0dc View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2021

  1. Handle individual paths

    @CyrusNajmabadi
    CyrusNajmabadi committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    e046cbb View commit details
    Browse the repository at this point in the history

  2. Extract code into helper types

    @CyrusNajmabadi
    CyrusNajmabadi committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    e3e9bea View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into removeEnum2

    @CyrusNajmabadi
    CyrusNajmabadi committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    5197dc9 View commit details
    Browse the repository at this point in the history

  4. Update src/Features/Core/Portable/NavigateTo/AbstractNavigateToSearch… 

    …Service.GeneratedDocumentSearch.cs
    @CyrusNajmabadi
    CyrusNajmabadi authored Nov 3, 2021
    Configuration menu
    Copy the full SHA
    83121ec View commit details
    Browse the repository at this point in the history

  5. Simplify

    @CyrusNajmabadi
    CyrusNajmabadi committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    22b9c0b View commit details
    Browse the repository at this point in the history

  6. Merge branch 'removeEnum2' of https://github.com/CyrusNajmabadi/roslyn … 

    …into removeEnum2
    @CyrusNajmabadi
    CyrusNajmabadi committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    9b11b72 View commit details
    Browse the repository at this point in the history

  7. Inline

    @CyrusNajmabadi
    CyrusNajmabadi committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    a1847b6 View commit details
    Browse the repository at this point in the history

  8. Complete the progress

    @CyrusNajmabadi
    CyrusNajmabadi committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    975084a View commit details
    Browse the repository at this point in the history

  9. Cancel property

    @CyrusNajmabadi
    CyrusNajmabadi committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    3c1b68a View commit details
    Browse the repository at this point in the history

  10. Update the progress API shape to make it easier to mark a set of work… 

    … as complete.
    @CyrusNajmabadi
    CyrusNajmabadi committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    e4334c1 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'progressApi' into removeEnum2

    @CyrusNajmabadi
    CyrusNajmabadi committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    101849e View commit details
    Browse the repository at this point in the history

  12. Simplify

    @CyrusNajmabadi
    CyrusNajmabadi committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    51dc674 View commit details
    Browse the repository at this point in the history

  13. Processing order

    @CyrusNajmabadi
    CyrusNajmabadi committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    a502c07 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2021

  1. Add measure

    @Cosifne
    Cosifne committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    09d214c View commit details
    Browse the repository at this point in the history

  2. Add comment

    @Cosifne
    Cosifne committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    d58346e View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into progressApi

    @CyrusNajmabadi
    CyrusNajmabadi committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    77dbfa3 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'progressApi' into removeEnum2

    @CyrusNajmabadi
    CyrusNajmabadi committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    ee5f748 View commit details
    Browse the repository at this point in the history

  5. Verify Smart Break Line behavior with tabs 

    Closes #57323
    @sharwell
    sharwell committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    bbf6f4c View commit details
    Browse the repository at this point in the history

  6. Use DocumentOptionSet instead of IEditorOptions for new line settings 

    Closes #57323
    @sharwell
    sharwell committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    b5686a8 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2021

  1. Fix flaky issue in the SourceGeneratorItemTests 

    I did .ContinueWith().CompletesAsyncOperation(), not realizing that
the task being returned from the ContinueWith was a Task<Task>; we'd
end up waiting for the first half but not the second half. A call to
Unwrap() fixes it.

Fixes #56826
    @jasonmalinowski
    jasonmalinowski committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    3e2c459 View commit details
    Browse the repository at this point in the history

  2. StackFrame Parser/Lexer as EmbeddedLanguage (#56957) 

    Add StackFrameParser to parse single line stackframe input and provide an EmbeddedSyntaxTree that represents the parsed data. Only provides implementation and tests. Follow up will be done to use this in the UI layer
    @ryzngard
    ryzngard authored Nov 5, 2021
    Configuration menu
    Copy the full SHA
    d3d009d View commit details
    Browse the repository at this point in the history

  3. Merge pull request #57538 from CyrusNajmabadi/removeEnum2 

    Have navto only search generated-documents after doing the search of regular documents.
    @CyrusNajmabadi
    CyrusNajmabadi authored Nov 5, 2021
    Configuration menu
    Copy the full SHA
    85522f1 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #57579 from sharwell/break-line 

    Use DocumentOptionSet in AutomaticLineEnderCommandHandler
    @sharwell
    sharwell authored Nov 5, 2021
    Configuration menu
    Copy the full SHA
    6ab724e View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'upstream/main' into dev/shech/Inheritan… 

    …ceMarginBenchMark
    @Cosifne
    Cosifne committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    77b8c0e View commit details
    Browse the repository at this point in the history

  6. Merge pull request #57004 from MaStr11/CodefixCS1591 

    Codefix for CS1591: Add ///<inheritdoc/>
    @sharwell
    sharwell authored Nov 5, 2021
    Configuration menu
    Copy the full SHA
    d4fd404 View commit details
    Browse the repository at this point in the history

  7. Revert to VS2019 for official build

    @JoeRobich
    JoeRobich authored Nov 5, 2021
    Configuration menu
    Copy the full SHA
    44f0576 View commit details
    Browse the repository at this point in the history

  8. Merge pull request #57593 from jasonmalinowski/fix-flaky-tests 

    Fix flaky issue in the SourceGeneratorItemTests
    @jasonmalinowski
    jasonmalinowski authored Nov 5, 2021
    Configuration menu
    Copy the full SHA
    4dcbb7c View commit details
    Browse the repository at this point in the history

  9. Clean up VsCodeWindowManager (#57582)

    @tmat
    tmat authored Nov 5, 2021
    Configuration menu
    Copy the full SHA
    97993be View commit details
    Browse the repository at this point in the history

  10. Validate the checksum of source on disk (#57541)

    @davidwengier
    davidwengier authored Nov 5, 2021
    Configuration menu
    Copy the full SHA
    d1b9b73 View commit details
    Browse the repository at this point in the history

  11. Revert to VS2019 for PR Validation

    @JoeRobich
    JoeRobich authored Nov 5, 2021
    Configuration menu
    Copy the full SHA
    9a4ccdd View commit details
    Browse the repository at this point in the history

  12. Merge pull request #57445 from Cosifne/dev/shech/InheritanceMarginBen… 

    …chMark

Benchmark for Inheritance Margin
    @Cosifne
    Cosifne authored Nov 5, 2021
    Configuration menu
    Copy the full SHA
    732a2ab View commit details
    Browse the repository at this point in the history

  13. Install .NET SDK in PR Validation pipeline

    @JoeRobich
    JoeRobich authored Nov 5, 2021
    Configuration menu
    Copy the full SHA
    efb6343 View commit details
    Browse the repository at this point in the history

  14. WIP

    @CyrusNajmabadi
    CyrusNajmabadi committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    ae9dea8 View commit details
    Browse the repository at this point in the history

  15. Simplify

    @CyrusNajmabadi
    CyrusNajmabadi committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    67594ae View commit details
    Browse the repository at this point in the history

  16. Add test

    @CyrusNajmabadi
    CyrusNajmabadi committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    df61bc6 View commit details
    Browse the repository at this point in the history

  17. Update src/Features/VisualBasic/Portable/NavigationBar/VisualBasicNav… 

    …igationBarItemService.vb
    @CyrusNajmabadi
    CyrusNajmabadi authored Nov 5, 2021
    Configuration menu
    Copy the full SHA
    aac6702 View commit details
    Browse the repository at this point in the history

  18. Revert

    @CyrusNajmabadi
    CyrusNajmabadi committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    2cc3af0 View commit details
    Browse the repository at this point in the history

  19. Less linq

    @CyrusNajmabadi
    CyrusNajmabadi committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    bc3d977 View commit details
    Browse the repository at this point in the history

  20. Don't crash Use ExpressionBody on local functions in top level statem… 

    …ents (#57571)
    @davidwengier
    davidwengier authored Nov 5, 2021
    Configuration menu
    Copy the full SHA
    9828d63 View commit details
    Browse the repository at this point in the history

  21. Merge remote-tracking branch 'upstream/main' into vbEvents

    @CyrusNajmabadi
    CyrusNajmabadi committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    1096066 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2021

  1. PR feedback

    @CyrusNajmabadi
    CyrusNajmabadi committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    929e309 View commit details
    Browse the repository at this point in the history

  2. Simplify

    @CyrusNajmabadi
    CyrusNajmabadi committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    fde963d View commit details
    Browse the repository at this point in the history

  3. Merge pull request #57606 from CyrusNajmabadi/vbEvents 

    Ensure we select a 'VB WithEvents' member in the navbar list when the user enters that member in the editor.
    @CyrusNajmabadi
    CyrusNajmabadi authored Nov 6, 2021
    Configuration menu
    Copy the full SHA
    441b10f View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2021

  1. Merge pull request #55123 from Youssef1313/patch-9

    @jmarolf
    jmarolf authored Nov 7, 2021
    Configuration menu
    Copy the full SHA
    a7324b0 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #54601 from Youssef1313/editorconfig-format

    @jmarolf
    jmarolf authored Nov 7, 2021
    Configuration menu
    Copy the full SHA
    ae8beb0 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2021

  1. Merge remote-tracking branch 'origin/main-vs-deps' into merges/main-t… 

    …o-main-vs-deps
    @JoeRobich
    JoeRobich committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    769c623 View commit details
    Browse the repository at this point in the history