Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back option to allow users to disable async lightbulbs #57808

Merged
merged 4 commits into from
Nov 22, 2021
Merged

Add back option to allow users to disable async lightbulbs #57808

merged 4 commits into from
Nov 22, 2021

Conversation

CyrusNajmabadi
Copy link
Member

We very much hope this will not be necessary to use. However, this is a hedge in case we discover any very late issue that we don't have time to address.

@CyrusNajmabadi CyrusNajmabadi requested review from a team as code owners November 17, 2021 01:48
@CyrusNajmabadi
Revert "Merge pull request dotnet#56858 from CyrusNajmabadi/enableAsy…
95223d1 
…ncLightbulbs17.1proper"

This reverts commit 4fc7245, reversing
changes made to 3ee34ed.
@ghost ghost added the Needs UX Triage label Nov 17, 2021
This was referenced Nov 17, 2021
Closed
Open
Closed
Closed
@CyrusNajmabadi CyrusNajmabadi merged commit 879cbef into dotnet:main Nov 22, 2021
@ghost ghost added this to the Next milestone Nov 22, 2021
@CyrusNajmabadi CyrusNajmabadi deleted the addBackAsyncLightbulbOptino branch November 22, 2021 17:12
@allisonchou allisonchou modified the milestones: Next, 17.1.P2 Nov 30, 2021
@ryzngard ryzngard added UX Review Not Required UX Review Not Required and removed Needs UX Triage labels Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinujoseph jinujoseph jinujoseph approved these changes

Assignees
No one assigned
Labels
Area-IDE UX Review Not Required UX Review Not Required
Projects
None yet
Milestone
17.1.P2
Development

Successfully merging this pull request may close these issues.
4 participants
@CyrusNajmabadi @jinujoseph @ryzngard @allisonchou