Merge PrimaryConstructors into Main #67124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For classes and structures: - Support parameters - Support base arguments - Support semicolon as body https://github.com/dotnet/csharplang/blob/main/proposals/primary-constructors.md#syntax
… in type-or-value scenarios (#66254) This PR matches the version of the spec from dotnet/csharplang#6855.
…g. (#66583) - Nullable analysis - Region analysis - Struct layout cycles - Misc.
This change also flags as rude EnC edits that might result in changes around captured primary constructor parameters: - Adding a capture - Removing a capture - Changing type of a captured parameter - Etc. The check is not meant to be able to accurately detect “safe” edits. The primary goal is to not let “unsafe” edits through.
This also includes the following public API changes: - TypeDeclarationSyntax.ParameterList becomes abstract - TypeDeclarationSyntax.WithParameterList is added - TypeDeclarationSyntax.AddParameterListParameters is added - InterfaceDeclarationSyntax.ParameterList is added as an override - InterfaceDeclarationSyntax.WithParameterList is added - InterfaceDeclarationSyntax.AddParameterListParameters is added - new overload of InterfaceDeclarationSyntax.Update is added - new overload of SyntaxFactory.InterfaceDeclaration is added - ClassDeclarationSyntax.ParameterList is changed to an override - StructDeclarationSyntax.ParameterList is changed to an override - RecordDeclarationSyntax.ParameterList is changed to an override. This API was previously shipped as a regular property.
jjonescz
approved these changes
Mar 1, 2023
ghost
added this to the 
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.