Merge 'dotnet/main' into PrimaryConstructors #66866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Project.HasSuccessfullyLoadedAsync logic
…-release/dev17.5-vs-deps Merge release/dev17.5 to release/dev17.5-vs-deps
…-main Merge release/dev17.6 to main
…-main Merge release/dev17.6 to main
Attempting to publish NuPkg files from a dev branch to avoid the need to insert into release/dev17.5. For reviewers. The intent here is *solely* to put our assets onto our AzDO NuGet feeds for consumption from razor. This branch is already mirror'd to AzDO, I can build it, we just need the assets on our package feeds so we can consume them for next month. Once 17.6 preview builds are available we can shift back to consuming `main` from roslyn.
NRT enable a language service
* Continued analyzer assembly loading work This change responds to several concerns raised in dotnet#66492: - Collapse the `AnalyzerAssembyLoader` hierarchy by one level and move more logic into the base type. - Fix `AssemblyLoadContext` in tests to not replicate types. That means we can safely pass `ITestOutputHelper` into the custom `AssemblyLoadContext` - Further strengthen the test separation I have deliberately not changed the file names to reflect the new type names because I wanted the review process to be smooth. Once I have two sign offs for the change I will send another commit which does the following: - Rename - DefaultAnalyzerAssemblyLoaderTests.cs -> AnalyzerAssemblyLoaderTests.cs - DefaultAnalyzerAssemblyLoader.Core.cs -> AnalyzerAssemblyLoader.Core.cs - DefaultAnalyzerAssemblyLoader.Desktop.cs -> AnalyzerAssemblyLoader.Desktop.cs - DefaultAnalyzerAssemblyLoader.cs -> AnalyzerAssemblyLoader.cs - Move - `DefaultAnalyzerAssemblyLoader` into DefaultAnalyzerAssemblyLoader.cs - `InvokeUtil` to InvokeUtil.cs. As constructed every edit to this type causes Test Explorer to lose context on the theory branches. Doesn't come back until rebuild. Will be smoother editting in its own file. That should get is into the style we expect here. After that I will merge once tests are green. * Unload AssemblyLoadContext after test completion * Reuse AssemblyLoadTestFixture across test runs This also has the added benefit that the entire .NET Core set of tests run in less than one second. Previously it close to half a second per test. This will hopefully alleviate the pain for the runtime issue we're hittnig running `AssemblyLoadContext` tests in CI. This reduces the amount of compilations on this code path which seem to be the trigger for the failure. - dotnet#66621 - dotnet/runtime#81108 * Apply suggestions from code review Co-authored-by: Rikki Gibson <rikkigibson@gmail.com> * PR feedback * rename the files * Fixup --------- Co-authored-by: Rikki Gibson <rikkigibson@gmail.com>
Avoid directory enumerations in DeleteLeftoverDirectories
…d has `Conditional` attribute
Fix formatting issue with convert-to-full-prop
* Abstractions + propg snippet * Implement propi snippet * Rename * Add clarification comment * Remove bad test (it was abstracted) * Revert "Rename" This reverts commit 4b6547d. * Suppress nullability warning * Rename base class to better indicate that it is abstract * Move abstract member to the top of the file * Make interface test case abstract * Again be clear in naming of abstract things
Co-authored-by: CyrusNajmabadi <cyrus.najmabadi@gmail.com>
Move the 'assign out parameter' fixer down to the CodeStyle layer
* 🔨 Enable MSBuild COMM log in bootstrap Fixed a gap where we were calling MSBuild without setting up the COMM log. This uses a bigger hammer approach by setting the ENV variables at the YML level.
Move the 'add parens in conditional' fixer down to the CodeStyle layer
Fix crash in FAR helpers when only part of a linked-document set has been updated
…uestConcurrency Dev/toddgrun/request concurrency
Move 'convert to async function' down to CodeStyle layer
Move 'use explicit type for constants' down to anlayzer layer
AlekseyTs
requested review from
a team,
333fred and
JoeRobich
as code owners
jjonescz
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.