Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package readmes are broken #106585

Closed
MSDN-WhiteKnight opened this issue Aug 18, 2024 · 2 comments · Fixed by #106590
Closed

Package readmes are broken #106585

MSDN-WhiteKnight opened this issue Aug 18, 2024 · 2 comments · Fixed by #106590
Assignees
@ViktorHofer
Labels
area-Infrastructure-libraries bug in-pr There is an active PR which will close this issue when it is merged
Milestone
9.0.0

Comments

@MSDN-WhiteKnight
Copy link
Contributor

MSDN-WhiteKnight commented Aug 18, 2024 •
edited
Loading

Description

Runtime packages have markdown readmes that should be rendered on NuGet gallery page. But latest preview version lost them, there's no package.md file in .nupkg, and NuGet gallery fallbacks to plaintext description. For example, for System.Reflection.Metadata 9.0.0-preview.6.24327.7 shows markdown readme, but 9.0.0-preview.7.24405.7 does not.

Reproduction Steps

Navigate to NuGet gallery page of the package, such as https://www.nuget.org/packages/System.Reflection.Metadata/9.0.0-preview.7.24405.7#readme-body-tab

Expected behavior

Should show markdown package readme, like for previous version:

readme-expected

Actual behavior

Shows plaintext description:

readme-broken

Regression?

Broken starting from latest version, 9.0.0-preview.7.24405.7

Known Workarounds

No response

Configuration

No response

Other information

No response
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Aug 18, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-reflection-metadata
See info in area-owners.md if you want to be subscribed.

@filipnavara filipnavara mentioned this issue Aug 18, 2024
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Aug 18, 2024
@filipnavara filipnavara added area-Infrastructure-libraries and removed in-pr There is an active PR which will close this issue when it is merged area-System.Reflection.Metadata labels Aug 18, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@ViktorHofer ViktorHofer self-assigned this Aug 18, 2024
@ViktorHofer ViktorHofer added bug and removed untriaged New issue has not been triaged by the area owner labels Aug 18, 2024
@ViktorHofer ViktorHofer added this to the 9.0.0 milestone Aug 18, 2024
ViktorHofer added a commit that referenced this issue Aug 18, 2024
@ViktorHofer
Fix condition for adding package readmes
8dd17ac 
Fixes #106585

The EnableDefualtPackageReadmeFile property needs to be defined before packaging.targets is imported.
@ViktorHofer ViktorHofer mentioned this issue Aug 18, 2024
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Aug 18, 2024
github-actions bot pushed a commit that referenced this issue Aug 18, 2024
@ViktorHofer
Fix condition for adding package readmes
94653e8 
Fixes #106585

The EnableDefualtPackageReadmeFile property needs to be defined before packaging.targets is imported.
github-actions bot pushed a commit that referenced this issue Aug 18, 2024
@ViktorHofer
Fix condition for adding package readmes
b014cdb 
Fixes #106585

The EnableDefualtPackageReadmeFile property needs to be defined before packaging.targets is imported.
ViktorHofer added a commit that referenced this issue Aug 19, 2024
@ViktorHofer
Fix condition for adding package readmes
5730681 
Fixes #106585

The EnableDefualtPackageReadmeFile property needs to be defined before packaging.targets is imported.
ViktorHofer added a commit that referenced this issue Aug 19, 2024
@ViktorHofer
Fix condition for adding package readmes
9ae5cb9 
Fixes #106585

The EnableDefualtPackageReadmeFile property needs to be defined before packaging.targets is imported.
carlossanlop pushed a commit that referenced this issue Aug 19, 2024
@github-actions @ViktorHofer
[release/9.0-rc1] Fix condition for adding package readmes (#106592)
2a9d9bc 
* Fix condition for adding package readmes

Fixes #106585

The EnableDefualtPackageReadmeFile property needs to be defined before packaging.targets is imported.

* Update workloads.csproj

---------

Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this issue Dec 10, 2024
@ViktorHofer @mikelle-rogers
Fix condition for adding package readmes (dotnet#106590)
f69aa07 
* Fix condition for adding package readmes 

Fixes dotnet#106585

The EnableDefualtPackageReadmeFile property needs to be defined before packaging.targets is imported.

* Enable package readme validation for everything in runtime
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ViktorHofer ViktorHofer

Labels
area-Infrastructure-libraries bug in-pr There is an active PR which will close this issue when it is merged
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

Fix condition for adding package readmes dotnet/runtime
3 participants
@filipnavara @ViktorHofer @MSDN-WhiteKnight