[release/9.0-rc1] Fix condition for adding package readmes #106592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
|
Sent mail to Tactics. Tell-mode because this is a major regression blocking our .NET 9 release. |
akoeplinger
approved these changes
Aug 19, 2024
ViktorHofer
force-pushed
the
backport/pr-106590-to-release/9.0-rc1
branch
from
b014cdb to
5730681
Compare
ViktorHofer
requested review from
sbomer,
lewing and
pavelsavara
as code owners
Fixes #106585 The EnableDefualtPackageReadmeFile property needs to be defined before packaging.targets is imported.
ViktorHofer
force-pushed
the
backport/pr-106590-to-release/9.0-rc1
branch
from
5730681 to
9ae5cb9
Compare
This was referenced Aug 19, 2024
sbomer
approved these changes
Aug 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #106590 to release/9.0-rc1
/cc @ViktorHofer
Customer Impact
Package readmes are an essential part of our shipping packages. Customers reported that those disappeared from our runtime packages between P6 and P7 which makes adopting our packages harder.
Regression
Regressed with e9ffa8c between P6 and P7.
Testing
Built the packages locally. The package readme file is now again part of the package.
Risk
Low, just an msbuild (build time) line change.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.