Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix condition for adding package readmes #106590

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Fix condition for adding package readmes #106590

merged 2 commits into from
Aug 19, 2024

Conversation

ViktorHofer
Copy link
Member

Fixes #106585
Regressed with e9ffa8c

The EnableDefualtPackageReadmeFile property needs to be defined before packaging.targets is imported.

Thanks for the report @MSDN-WhiteKnight

@ViktorHofer
Fix condition for adding package readmes
8dd17ac 
Fixes #106585

The EnableDefualtPackageReadmeFile property needs to be defined before packaging.targets is imported.
@ViktorHofer ViktorHofer requested a review from a team August 18, 2024 18:15
@ViktorHofer
Copy link
Member Author

/backport to release/9.0

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10442768239

@github-actions github-actions bot mentioned this pull request Aug 18, 2024
Closed
4 tasks
@ViktorHofer
Copy link
Member Author

/backport to release/9.0-rc1

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/9.0-rc1: https://github.com/dotnet/runtime/actions/runs/10442943879

@github-actions github-actions bot mentioned this pull request Aug 18, 2024
Merged
4 tasks
This was referenced Aug 18, 2024
Open
Open
@ViktorHofer ViktorHofer merged commit ca99ff4 into main Aug 19, 2024
161 of 163 checks passed
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-3 branch August 19, 2024 10:52
@lewing
Copy link
Member

lewing commented Aug 19, 2024

this is breaking the official build in the workload step https://dev.azure.com/dnceng/internal/_build/results?buildId=2518856&view=logs&j=7bf215f5-1c95-5bbd-4005-575fc2c46c79&t=88f8f928-3551-5dff-d5e2-be29d98ae725&l=1677

@ViktorHofer
Copy link
Member Author

ViktorHofer commented Aug 19, 2024 •
edited
Loading

Ok, looking. Don't we build workloads in PRs?

Here's the fix: https://github.com/dotnet/runtime/pull/106638/files

ViktorHofer added a commit that referenced this pull request Aug 19, 2024
@ViktorHofer
Update workloads.csproj
a25bc35 
Fixes the official build break. Regressed with #106590
@ViktorHofer ViktorHofer mentioned this pull request Aug 19, 2024
Merged
@lewing
Copy link
Member

lewing commented Aug 19, 2024

Ok, looking. Don't we build workloads in PRs?

Here's the fix: https://github.com/dotnet/runtime/pull/106638/files

We build the nugets that the sdk uses but we don't build the msis that VS uses in PRs

ViktorHofer added a commit that referenced this pull request Aug 19, 2024
@ViktorHofer
Update workloads.csproj (#106638)
67631f5 
* Update workloads.csproj

Fixes the official build break. Regressed with #106590

* Update workloads.csproj
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

@sbomer sbomer Awaiting requested review from sbomer sbomer is a code owner

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara is a code owner

Assignees

@ViktorHofer ViktorHofer

Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package readmes are broken
3 participants
@ViktorHofer @lewing @akoeplinger