Rollback changes breaking rolling builds #60040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsAll of the rolling builds since 9/30 are broken by those 3 changes. I've tried rolling them back individually:
|
safern
approved these changes
Oct 5, 2021
There was a problem hiding this comment.
LGTM, thanks! @aik-jahoda we should schedule a rolling build for the new additions when we try and add them back.
|
I'm merging because build has already been run for this change and there is no point on doing subset testing (linked in the pr description) |
This was referenced Oct 6, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the rolling builds since 9/30 are broken by those 3 changes.
I've tried rolling them back individually:
and seems to me each one of them decreases total number of failures which build shows but doesn't bring it to 0. Reverting all 3 gives almost green build (single flaky test):