Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI matrix: add openSUSE 15.2 - second attempt #60161

Merged
merged 6 commits into from
Dec 8, 2021

Conversation

aik-jahoda
Copy link
Contributor

The original CI matrix change was reverted (#60040) because of a failing CI.

part of #57947

original PR: #59574

@ghost
Copy link

ghost commented Oct 8, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

The original CI matrix change was reverted (#60040) because of a failing CI.

part of #57947

original PR: #59574

Author: aik-jahoda
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@aik-jahoda aik-jahoda changed the title CI matrix: add openSUSE 15.2 (#59574) CI matrix: add openSUSE 15.2 - second attempt Oct 8, 2021
@safern
Copy link
Member

safern commented Oct 8, 2021

@aik-jahoda did you run a manual runtime build from your branch? It seems like opensuse is missing fonts and the System.Drawing.Tests are failing because of that.

@aik-jahoda
Copy link
Contributor Author

@safern All test are passed and we can merge it. Can you please review?

@aik-jahoda aik-jahoda requested review from safern and a team November 25, 2021 13:03
@karelz
Copy link
Member

karelz commented Nov 29, 2021

@safern @ericstj can you please review the PR? Then we can merge (and backport to .NET 6.0). Thanks!

@karelz karelz requested a review from ericstj November 29, 2021 15:56
@ericstj
Copy link
Member

ericstj commented Nov 29, 2021

From previous review:

did you run a manual runtime build from your branch?

I looked through the logs from this PR to find where this is running on the queue you added and can't find it:
https://dev.azure.com/dnceng/public/_build/results?buildId=1484879&view=logs&j=71afe768-e493-597c-228c-037834193aeb&t=fe87d331-02fa-5ca6-e382-69b0a11bb0f6

Perhaps you can share the link to the build which tested your changes?

@aik-jahoda
Copy link
Contributor Author

@krwq I'm little bit lost with build, I have followed your suggestion from #60054 (comment) however I can't see any openSUSE tests:
https://dev.azure.com/dnceng/public/_build/results?buildId=1490317&view=results

Could it be caused by ne(parameters.jobParameters.isSingleFile, true) when this branch contains change only on one file?

@safern
Copy link
Member

safern commented Dec 2, 2021

I don't think we need to touch another file. Where did you see that condition?

The change looks good, I just triggered another pipeline and when done I can help you getting the open suse test results:
https://dnceng.visualstudio.com/public/_build/results?buildId=1494706&view=results

@aik-jahoda
Copy link
Contributor Author

@safern
Copy link
Member

safern commented Dec 7, 2021

Mono runtime tests are also unrelated.

@aik-jahoda aik-jahoda merged commit a0824ba into main Dec 8, 2021
@aik-jahoda aik-jahoda deleted the jajahoda/cimatrixopensuse branch December 8, 2021 17:17
@ghost ghost locked as resolved and limited conversation to collaborators Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants