Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RISC-V] Call missing genProduceReg in genCodeForCompare #97805

Merged
merged 1 commit into from
Feb 1, 2024
Merged

[RISC-V] Call missing genProduceReg in genCodeForCompare #97805

merged 1 commit into from
Feb 1, 2024

Conversation

tomeksowi
Copy link
Contributor

This fixes among others CLR tests from baseservices/threading/generics, uncovered after LSRA MinOpts optimization in #96386.

Part of #84834
cc @wscho77 @HJLeee @clamp03 @JongHeonChoi @t-mustafin @gbalykov @viewizard @ashaurtaev @brucehoult @sirntar @yurai007 @Bajtazar

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 1, 2024
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Feb 1, 2024
@ghost
Copy link

ghost commented Feb 1, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This fixes among others CLR tests from baseservices/threading/generics, uncovered after LSRA MinOpts optimization in #96386.

Part of #84834
cc @wscho77 @HJLeee @clamp03 @JongHeonChoi @t-mustafin @gbalykov @viewizard @ashaurtaev @brucehoult @sirntar @yurai007 @Bajtazar

Author: tomeksowi
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

@clamp03 clamp03 added the arch-riscv Related to the RISC-V architecture label Feb 1, 2024
@ryujit-bot
Copy link

Diff results for #97805

Throughput diffs

Throughput diffs for windows/arm64 ran on windows/x64

MinOpts (-0.01% to +0.00%)
Collection PDIFF
libraries.pmi.windows.arm64.checked.mch -0.01%

Details here

@build-analysis build-analysis bot mentioned this pull request Feb 1, 2024
Open
3 tasks
@tomeksowi tomeksowi marked this pull request as ready for review February 1, 2024 12:15
@clamp03 clamp03 requested a review from jakobbotsch February 1, 2024 12:23
@jakobbotsch jakobbotsch merged commit 52e1ad3 into dotnet:main Feb 1, 2024
127 of 129 checks passed
@brucehoult
Copy link

LGTM

@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bajtazar Bajtazar Bajtazar approved these changes

@ashaurtaev ashaurtaev ashaurtaev approved these changes

@yurai007 yurai007 yurai007 approved these changes

@jakobbotsch jakobbotsch jakobbotsch approved these changes

@clamp03 clamp03 clamp03 approved these changes

Assignees

@tomeksowi tomeksowi

Labels
arch-riscv Related to the RISC-V architecture area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tomeksowi @ryujit-bot @brucehoult @clamp03 @jakobbotsch @yurai007 @ashaurtaev @Bajtazar