Better caching for RazorSourceGenerator when SuppressRazorSourceGener… #23358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
Area-AspNetCore
chsienki
reviewed
Jan 10, 2022
chsienki
approved these changes
Jan 10, 2022
…ator changes In VisualStudio SuppressRazorSourceGenerator changes when it's being invoked by the EnC and tooling. In our current implementation, while we no-op the operation, when SuppressRazorSourceGenerator=true, the code also evicts the valid previously cached results when SuppressRazorSourceGenerator=false by returning null values, causing us do work the next time its false.
pranavkm
force-pushed
the
prkrishn/razor-caching
branch
from
a0393ef to
5f7d579
Compare
| /// For instance <c>dotnet msbuild /p:_RazorSourceGeneratorDebug=true</c> | ||
| /// </para> | ||
| /// </summary> | ||
| public bool WaitForDebugger { get; set; } = false; |
There was a problem hiding this comment.
Any motivation for removing the debug flag?
There was a problem hiding this comment.
We stopped using it when we migrated to the incremental APIs. You kinda need to break inside one of the steps for this to work reliably and we never did that.
pranavkm
added a commit
that referenced
this pull request
Jan 13, 2022
…ator changes (#23358) In VisualStudio SuppressRazorSourceGenerator changes when it's being invoked by the EnC and tooling. In our current implementation, while we no-op the operation, when SuppressRazorSourceGenerator=true, the code also evicts the valid previously cached results when SuppressRazorSourceGenerator=false by returning null values, causing us do work the next time its false. Contributes to dotnet/aspnetcore#32867
pranavkm
added a commit
that referenced
this pull request
Jan 25, 2022
…ator changes (#23358) (#23419) In VisualStudio SuppressRazorSourceGenerator changes when it's being invoked by the EnC and tooling. In our current implementation, while we no-op the operation, when SuppressRazorSourceGenerator=true, the code also evicts the valid previously cached results when SuppressRazorSourceGenerator=false by returning null values, causing us do work the next time its false. Contributes to dotnet/aspnetcore#32867
chsienki
added a commit
to chsienki/sdk
that referenced
this pull request
Mar 24, 2022
…rceGenerator changes (dotnet#23358)" This reverts commit a9b8bed.
Merged
chsienki
added a commit
to chsienki/sdk
that referenced
this pull request
Mar 25, 2022
…rceGenerator changes (dotnet#23358)" This reverts commit a9b8bed.
Merged
marcpopMSFT
added a commit
that referenced
this pull request
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ator changes
In VisualStudio SuppressRazorSourceGenerator changes when it's being invoked by the EnC and tooling.
In our current implementation, while we no-op the operation, when SuppressRazorSourceGenerator=true,
the code also evicts the valid previously cached results when SuppressRazorSourceGenerator=false by returning null values,
causing us do work the next time its false.
Fixes dotnet/aspnetcore#32867