Better caching for RazorSourceGenerator when SuppressRazorSourceGener… #23419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ator changes (#23358) In VisualStudio SuppressRazorSourceGenerator changes when it's being invoked by the EnC and tooling. In our current implementation, while we no-op the operation, when SuppressRazorSourceGenerator=true, the code also evicts the valid previously cached results when SuppressRazorSourceGenerator=false by returning null values, causing us do work the next time its false. Contributes to dotnet/aspnetcore#32867
dotnet-issue-labeler
bot
added
the
Area-AspNetCore
|
I see the do not merge has been added. We are eagerly awaiting this fix so our large Blazor project can use hot reload in VS. At the moment its too slow to use. |
5 tasks
|
@mikes-gh my plan is to get this merged in the 6.0.3xx release which aligns with VS 17.2. The code involves quite a bit of how the source generator caches and there's a very real risk that we introduce subtle caching bugs that weren't caught in local testing. Putting it in the 17.2 preview builds gives us a bit more time to address bugs while gathering feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ator changes (#23358)
In VisualStudio SuppressRazorSourceGenerator changes when it's being invoked by the EnC and tooling.
In our current implementation, while we no-op the operation, when SuppressRazorSourceGenerator=true,
the code also evicts the valid previously cached results when SuppressRazorSourceGenerator=false by returning null values, causing us do work the next time its false.
Contributes to dotnet/aspnetcore#32867
Backport #23358 to 6.0.2xx