Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDK-PR-guide.md to include branch lockdown label #46337

Merged
merged 22 commits into from
Feb 13, 2025

Conversation

marcpopMSFT
Copy link
Member

@marcpopMSFT marcpopMSFT commented Jan 27, 2025

I included a comment in the PR guide about the lockdown label
Additionally, I added a workflow to automatically add that label.

  • The branch is generally open between the first tuesday of the month when branding goes in until the third tuesday of the month (basically a week after the internal to public merge).
  • Outside of that window, let's automatically add the label to any 8/9 base branch PR
  • The workflow uses the permissions of the target branch as well as the source for the target branch so won't run until it's merged
  • I configured it to run on all PRs but will only check into main.
  • When it runs, it'll search all PRs and label them all so we don't need to configure it to run elsewhere.
  • I check if it's a PR against the 8 or 9 branches filtering out 9.0.3xx
  • I check if it already has the label

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Jan 27, 2025
@marcpopMSFT marcpopMSFT requested a review from baronfel January 27, 2025 20:54
.github/workflows/add-lockdown-label.yml Outdated Show resolved Hide resolved
.github/workflows/add-lockdown-label.yml Outdated Show resolved Hide resolved
.github/workflows/add-lockdown-label.yml Show resolved Hide resolved
.github/workflows/add-lockdown-label.yml Outdated Show resolved Hide resolved
@marcpopMSFT
Copy link
Member Author

/backport to release/9.0.2xx

Copy link
Contributor

Started backporting to release/9.0.2xx: https://github.com/dotnet/sdk/actions/runs/13079866389

The prior version of this would only label new PRs not PRs created before the date. This searches all PRs that match the requirements whenever a new PR is created targeting these branches.
@marcpopMSFT marcpopMSFT merged commit dcf869f into main Feb 13, 2025
39 checks passed
@marcpopMSFT marcpopMSFT deleted the marcpopMSFT-addbranchlockdown branch February 13, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants