-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/9.0.2xx] Update SDK-PR-guide.md to include branch lockdown label #46449
[release/9.0.2xx] Update SDK-PR-guide.md to include branch lockdown label #46449
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the .yml for GitHub actions need to exist outside of the default branch? The branches-ignore
would get troublesome to maintain on multiple branches.
I removed the 3xx from the branches-ignore but you bring up a good point about maintaining the list of branches to cover. Perhaps I only need this in main as it applies to all branches with the current version and we just have to keep the list updated there as it only ever adds things later. |
Ok, updated the main PR. It'll start running on any new main PR but apply to all servicing PRs. We can add additional branches in main and manage it only there and just not worry about porting changes around. While theoretically if we didn't get any main prs, it would never trigger, I'm not too worried about that. |
Backport of #46337 to release/9.0.2xx
/cc @marcpopMSFT