Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0.2xx] Update SDK-PR-guide.md to include branch lockdown label #46449

Closed

Conversation

github-actions[bot]
Copy link
Contributor

Backport of #46337 to release/9.0.2xx

/cc @marcpopMSFT

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Jan 31, 2025
Copy link
Member

@MiYanni MiYanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the .yml for GitHub actions need to exist outside of the default branch? The branches-ignore would get troublesome to maintain on multiple branches.

@marcpopMSFT
Copy link
Member

Does the .yml for GitHub actions need to exist outside of the default branch? The branches-ignore would get troublesome to maintain on multiple branches.

I removed the 3xx from the branches-ignore but you bring up a good point about maintaining the list of branches to cover. Perhaps I only need this in main as it applies to all branches with the current version and we just have to keep the list updated there as it only ever adds things later.

@marcpopMSFT
Copy link
Member

Ok, updated the main PR. It'll start running on any new main PR but apply to all servicing PRs. We can add additional branches in main and manage it only there and just not worry about porting changes around. While theoretically if we didn't get any main prs, it would never trigger, I'm not too worried about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants