Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature #2496 v11.0.2 second try #2500

Merged
merged 6 commits into from
Mar 31, 2023
Merged

Feature #2496 v11.0.2 second try #2500

merged 6 commits into from
Mar 31, 2023

Conversation

jprestop
Copy link
Collaborator

@jprestop jprestop commented Mar 31, 2023 •
edited
Loading

Recreating v11.0.2 release to update the version number in one more location that I missed yesterday.

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

None

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Please review the files changed.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [20230330].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@jprestop jprestop added this to the MET 11.0.2 (bugfix) milestone Mar 31, 2023
@JohnHalleyGotway JohnHalleyGotway changed the title Feature 2496 v11.0.2 Feature #2496 v11.0.2 second try Mar 31, 2023
JohnHalleyGotway
JohnHalleyGotway approved these changes Mar 31, 2023
View reviewed changes
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of this PR.

Sorry I'd missed updating the MET version number in the last one. I did update the title of the PR to indicate that this is second try.

I don't understand all the diffs highlighted in this PR: https://github.com/dtcenter/MET/pull/2500/files

Many of these changes have already been merged into main_v11.0 so I don't know why they are highlighted again. Regardless, I approve of these changes.

@jprestop jprestop merged commit 7f32d7e into main_v11.0 Mar 31, 2023
@jprestop jprestop deleted the feature_2496_v11.0.2 branch March 31, 2023 16:09
@jprestop jprestop linked an issue Mar 31, 2023 that may be closed by this pull request
Create the MET-11.0.2 release #2496
Closed
19 tasks
@JohnHalleyGotway JohnHalleyGotway mentioned this pull request Apr 3, 2023
Merged
JohnHalleyGotway added a commit that referenced this pull request Apr 3, 2023
@JohnHalleyGotway
Update main_v11.0-ref after #2500 (#2502)
e7ff10f 
Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>
Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Co-authored-by: jprestop <jpresto@ucar.edu>
Co-authored-by: hsoh-u <hsoh@ucar.edu>
Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
fix #2389 main_v11.0 flowchart (#2391)
fix definitions of G172 and G220 based on comments in NOAA-EMC/NCEPLIBS-w3emc#157. (#2405)
fix #2380 main_v11.0 override (#2381)
fix #2408 main_v11.0 empty config (#2409)
fix #2390 main_v11.0 fix compiling hdf5 with zlib and handle NetCDF-C zip (#2403)
fix #2415 main_v11.0 modulefiles (#2416)
fix #2412 main_v11.0 climo (#2420)
fix #2426 main_v11.0 buoy (#2432)
fix #2437 main_v11.0 convert (#2438)
fix for main_v11.0, for #2437, forgot one reference to the search_parent for a dictionary lookup.
fix 2428 python from env main v11.0 (#2443)
fix 2428 python csv input (#2450)
fix #2452 main_v11.0 airnow (#2453)
fix #2402 main_v11.0 sonarqube (First PR) (#2447)
fix #2449 main_v11.0 pdf (#2465)
fix 2428 python csv input (#2467)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnHalleyGotway JohnHalleyGotway JohnHalleyGotway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Coordinated METplus-5.0 Support
Status: ✅ Done
Milestone
MET 11.0.2 (bugfix)
Development

Successfully merging this pull request may close these issues.

Create the MET-11.0.2 release
2 participants
@jprestop @JohnHalleyGotway