Bugfix #2412 main_v11.0 climo

[JohnHalleyGotway]

Expected Differences

These code changes are more substantial than I was hoping. However, I think the resulting logic and log messages are both more clear and intuitive. For each climo record being considered, the code now computes 2 time differences: the number of DAYS that differ and the number of HMS seconds that differ. These are both stored as a +/- time offset relative to the forecast valid time in seconds.

The day difference is checked against the day_interval config entry. And the hms difference is checked against the hour_interval config entry.

• Do these changes introduce new tools, command line arguments, or configuration file options? [No]
  
  If yes, please describe:
  

• Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
  
  If yes, please describe:
  

Pull Request Testing

• Describe testing already performed for these changes:
  
  Tested a variety of different climo dates in seneca:/d1/projects/MET/MET_pull_requests/met-11.0.1/issue_2242/test_climo as the met_test user.

Test after Dec 15th:

./test_climo.sh 20201225_06
DEBUG 3: For forecast valid at 20201225_060000, found 2 climatology field(s) with valid time(s): 20201215_060000, 20210115_060000
DEBUG 3: Interpolating climatology fields at 20201215_060000 and 20210115_060000 to 20201225_060000 using the DW_MEAN interpolation method.

Test before Jan 15:

./test_climo.sh 20200105_03
DEBUG 3: For forecast valid at 20200105_030000, found 4 climatology field(s) with valid time(s): 20191215_000000, 20191215_060000, 20200115_000000, 20200115_060000
DEBUG 3: Interpolating climatology fields at 20191215_000000 and 20200115_000000 to 20200105_000000 using the DW_MEAN interpolation method.
DEBUG 3: Interpolating climatology fields at 20191215_060000 and 20200115_060000 to 20200105_060000 using the DW_MEAN interpolation method.
DEBUG 3: Interpolating climatology fields at 20200105_000000 and 20200105_060000 to 20200105_030000 using the DW_MEAN interpolation method.

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  

• Review the logic of the code changes.

• Could test with more dates on seneca. Could also test with daily climo files rather than just these monthly ones.

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
  I made no doc changes.

• Do these changes include sufficient testing updates? [No]
  I did not add tests for the main_v11.0 branch. However, I do plan to add them for these changes in the develop branch with a separate PR.

• Will this PR result in changes to the test suite? [No]
  
  If yes, describe the new output and/or changes to the existing output:
  

• Please complete this pull request review by [Tues 1/24/23].
  

Pull Request Checklist

See the METplus Workflow for details.

• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s)
  Select: Organization level software support Project or Repository level development cycle Project
  Select: Milestone as the version that will include these changes
• After submitting the PR, select Development issue with the original issue number.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[j-opatz]

I tested the feature branch against monthly and daily climatology files, both of which successfully temporally interpolated the expected files, regardless of the requested valid time and date. While it's harder to comment on the exact method of how this was accomplished with the code changes, it seems that providing the day > hour > interpolate logic method has the intended effect. The additional log comments are also greatly appreciated and will no doubt provide users with a better understanding of the back-end logic.