Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix 2596 main v11.0 rpath compilation #2600

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Bugfix 2596 main v11.0 rpath compilation #2600

merged 3 commits into from
Jul 13, 2023

Conversation

jprestop
Copy link
Collaborator

@jprestop jprestop commented Jul 3, 2023 •
edited
Loading

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    Tested compilation on narya using the gcc version 12.3.0 compiler. After reproducing the problem described in the issue, I was able to resolve the problem with these changes to the script and got a successful compilation and a successful run of "make test". I also tested the changes in the script with the gcc version 12.1.0 compiler on cheyenne and got a successful compilation and a successful run of "make test".

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    No testing needed. Review the files that changed and ensure that all tests pass. Could compile on a machines using gcc version 12.3.0 if desired.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [20230710].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@jprestop jprestop added this to the MET 11.0.3 (bugfix) milestone Jul 3, 2023
@jprestop jprestop requested a review from hsoh-u July 3, 2023 20:53
@jprestop jprestop linked an issue Jul 3, 2023 that may be closed by this pull request
Bugfix: Unknown ld Flag on Macos causes MET compilation to fail #2596
Closed
22 tasks
hsoh-u
hsoh-u approved these changes Jul 3, 2023
View reviewed changes
Copy link
Collaborator

@hsoh-u hsoh-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this changes.

There is an instance without major version :

  • internal/scripts/installation/config/install_met_env.generic:export COMPILER=gnu

This causes the same value "gnu" for all three: COMPILER_FAMILY, COMPILER_MAJOR_VERSION, and COMPILER_MINOR_VERSION. It does not cause a problem at seneca (it seems to convert the string "gnu" to integer for the major and minor versions with "if xxx -ge 12"). It would be nice to set to 0 if "COMPILER_FAMILY is the same asCOMPILER_MAJOR_VERSION.

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Jul 12, 2023 •
edited
Loading

@hsoh-u and @jprestop just following up on this PR. Looks like its been approved for a week. Julie, can you please merge it assuming its ready?

@jprestop
Copy link
Collaborator Author

@JohnHalleyGotway It's not quite ready yet. Please see this comment on this issue:
#2596 (comment)

@jprestop
Copy link
Collaborator Author

@JohnHalleyGotway Do you want me to close the PR instead of letting it sit? I haven't been able to get back to this work yet.

@jprestop jprestop merged commit d9f3ad3 into main_v11.0 Jul 13, 2023
@HathewayWill HathewayWill mentioned this pull request Jul 15, 2023
Closed
22 tasks
JohnHalleyGotway pushed a commit that referenced this pull request Sep 11, 2023
@github-actions
Update main_v11.0-ref after 11.0.3 release (#2678) (#2679)
42f672e 
Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>
Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Co-authored-by: jprestop <jpresto@ucar.edu>
Co-authored-by: hsoh-u <hsoh@ucar.edu>
Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
Co-authored-by: lisagoodrich <33230218+lisagoodrich@users.noreply.github.com>
Co-authored-by: Stephen Herbener <32968781+srherbener@users.noreply.github.com>
fix #2389 main_v11.0 flowchart (#2391)
fix definitions of G172 and G220 based on comments in NOAA-EMC/NCEPLIBS-w3emc#157. (#2405)
fix #2380 main_v11.0 override (#2381)
fix #2408 main_v11.0 empty config (#2409)
fix #2390 main_v11.0 fix compiling hdf5 with zlib and handle NetCDF-C zip (#2403)
fix #2415 main_v11.0 modulefiles (#2416)
fix #2412 main_v11.0 climo (#2420)
fix #2426 main_v11.0 buoy (#2432)
fix #2437 main_v11.0 convert (#2438)
fix for main_v11.0, for #2437, forgot one reference to the search_parent for a dictionary lookup.
fix 2428 python from env main v11.0 (#2443)
fix 2428 python csv input (#2450)
fix #2452 main_v11.0 airnow (#2453)
fix #2402 main_v11.0 sonarqube (First PR) (#2447)
fix #2449 main_v11.0 pdf (#2465)
fix 2428 python csv input (#2467)
fix #2514 main_v11.0 clang (#2556)
fix #2575 main_v11.0 python_convert (#2577)
fix 2596 main v11.0 rpath compilation (#2600)
fix 2596 main v11.0 rpath compilation (#2613)
fix #2644 main_v11.0 percentile (#2645)
JohnHalleyGotway added a commit that referenced this pull request Dec 18, 2023
@JohnHalleyGotway
Update main_v11.0-ref after #2761 upgraded seneca to Debian Bookworm (#…
2bf872c 
…2770)

Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>
Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Co-authored-by: jprestop <jpresto@ucar.edu>
Co-authored-by: hsoh-u <hsoh@ucar.edu>
Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
Co-authored-by: lisagoodrich <33230218+lisagoodrich@users.noreply.github.com>
Co-authored-by: Stephen Herbener <32968781+srherbener@users.noreply.github.com>
fix #2389 main_v11.0 flowchart (#2391)
fix definitions of G172 and G220 based on comments in NOAA-EMC/NCEPLIBS-w3emc#157. (#2405)
fix #2380 main_v11.0 override (#2381)
fix #2408 main_v11.0 empty config (#2409)
fix #2390 main_v11.0 fix compiling hdf5 with zlib and handle NetCDF-C zip (#2403)
fix #2415 main_v11.0 modulefiles (#2416)
fix #2412 main_v11.0 climo (#2420)
fix #2426 main_v11.0 buoy (#2432)
fix #2437 main_v11.0 convert (#2438)
fix for main_v11.0, for #2437, forgot one reference to the search_parent for a dictionary lookup.
fix 2428 python from env main v11.0 (#2443)
fix 2428 python csv input (#2450)
fix #2452 main_v11.0 airnow (#2453)
fix #2402 main_v11.0 sonarqube (First PR) (#2447)
fix #2449 main_v11.0 pdf (#2465)
fix 2428 python csv input (#2467)
fix #2514 main_v11.0 clang (#2556)
fix #2575 main_v11.0 python_convert (#2577)
fix 2596 main v11.0 rpath compilation (#2600)
fix 2596 main v11.0 rpath compilation (#2613)
fix #2644 main_v11.0 percentile (#2645)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsoh-u hsoh-u hsoh-u approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Coordinated METplus-5.0 Support
Status: ✅ Done
Milestone
MET 11.0.3 (bugfix)
Development

Successfully merging this pull request may close these issues.

Bugfix: Unknown ld Flag on Macos causes MET compilation to fail
3 participants
@jprestop @JohnHalleyGotway @hsoh-u